On 9/10/07, <b class="gmail_sendername">spaetz</b> <<a href="mailto:osm@sspaeth.de">osm@sspaeth.de</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Mon, Sep 10, 2007 at 10:41:47AM +1000, Brett Henderson wrote:<br>> **** 1. Different version number.<br><br>Shouldn't pose a problem IMHO<br><br>> **** 2. Lack of bound elements.<br>> planet.rb adds this element at the top of the file:
<br>> <bound box="-90,-180,90,180"<br>> origin="<a href="http://www.openstreetmap.org/api/0.4">http://www.openstreetmap.org/api/0.4</a>" /><br><br>That has been added rather recently by kleptog, to have a origin tag in there. But it worked without until recently, so it shouldn't be a problem either.
<br><br>> planet.rb writes node attributes in the order id, lat, lon, timestamp.<br>> osmosis writes node attributes in the order id, timestamp, user, lat, lon<br><br>I wonder how much larger the resulting file becomes with user id. Given that restricting the number of decimal places in lat/lon saved us 20MB in the resulting bz2, this could be a noticable amount. Do we fulfil our attribution requirements with this, or would we have to deliver a full list of users who modified that element in order to do that? Do people think the user id is important in
planet.osm?</blockquote><div><br>Yes. The user Id is very important. Otherwise you cannot use osmosis to drive a replication server.<br><br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> **** 4. Additional indenting whitespace.<br>> osmosis is currently using 4 space indenting, planetrb is using 2 space<br>> indenting.<br>> I can change osmosis to use 2 space indenting if it helps reduce file
<br>> sizes. Should I drop it to 1 space indenting to further reduce file size?<br><br>I'd let's compare the bzipped file size to see whether it makes a noticeable difference (I would think not, but haven't tested it).
<br><br>> **** 5. Inclusion of database password on command line.<br>> Currently the only way to provide a database password to osmosis is on<br>> the command line. Presumably this will allow other users on the same
<br>> system to see the password (through the use of ps, top, etc). If this<br>> is a problem I'll have to update the database tasks to be able to read a<br>> properties file containing connection information.
<br><br>Mmh, every user on dev would now be able to see the password with which to connect to the db server. I would *prefer* if we could find a non-commandline variant of handling that. It is not critical by any means (I hope dev users are a responsible lot), but then...
<br><br>> **** 6. Minimum of Java 1.6<br>> Dev currently has jdk1.5 installed preventing osmosis from running. The<br>> only code requiring 1.6 is the --bounding-polygon task.<br>> I have two options:<br>> a. Rework osmosis to only require
1.5 (either by temporarily deleting<br>> the polygon task, creating a branch without the polygon task, reworking<br>> the polygon task to use older features, etc).<br>> b. Upgrade dev to jdk 1.6.<br><br>I upgraded dev's java to
1.6 and it works fine. So this is no issue for me any more.<br><br>> **** 7. Different rounding of lat/lon coordinates.<br>> The java DecimalFormat appears to be rounding numbers in a slightly<br>> different way to whatever
planet.rb is using (sprintf?). This only<br>> occurs when a 5 has to be rounded one way or the other. I don't think<br>> this is an issue and short of writing my own decimal formatter I don't<br>> think there's much I can do about this one.
<br><br>I am doing a test dump on dev and will look at UTF-8 characters to see that it works out well on this box. Will let you know about the timing as well.<br><br>_______________________________________________<br>dev mailing list
<br><a href="mailto:dev@openstreetmap.org">dev@openstreetmap.org</a><br><a href="http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/dev">http://lists.openstreetmap.org/cgi-bin/mailman/listinfo/dev</a><br><br><br></blockquote>
</div><br>