<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hey Pascal,<br>
<br>
sounds good. Would really like to see it in code and invite you to
do a pull request! Did you apply this to the whole world or a
smaller area?<br>
<br>
> I have an aditional question: can you tell me where does the
autocomplete in <a moz-do-not-send="true"
href="http://graphhopper.com/maps">graphhopper.com/maps</a> come
from ?<br>
<br>
Also from the <a href="http://graphhopper.com/#enterprise">GraphHopper
Web API</a>, where technically the address suggestion comes from
the <a href="https://github.com/komoot/photon">photon</a> project
which uses ElasticSearch.<br>
<br>
Regards,<br>
Peter.<br>
<br>
<br>
</div>
<blockquote cite="mid:AAFC2908-BCC9-4BB2-9DC8-A37041C826CA@kds.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
Hello,
<div><br>
</div>
<div>So we finally implemented a change which work for us:</div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Compare to:</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://graphhopper.com/maps/?point=nice&point=saint%20paul%20de%20vence">http://graphhopper.com/maps/?point=nice&point=saint%20paul%20de%20vence</a></div>
<div><br>
</div>
<div>Here is the algorithm :</div>
<div><br>
</div>
<div>
<div style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-GB">-
First loop on nodes using a one-way explorer ;</span></div>
<div style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-GB">- </span>It
gives a list of all the sub-networks with their size ;</div>
<div style="margin: 0cm 0cm 0.0001pt;">- Sort the list by size
(bigger first) in order to keep the big networks and kill all
small networks (size < minNetworkSize). We can use another
property if necessary.</div>
<p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><span
lang="EN-GB">- </span>For each sub-network (identified by
its first nodeid) explore all nodes starting from this nodeId
and not in the big networks (>minNetworkSize) and remove
them ;</p>
<p class="MsoNormal" style="margin: 0cm 0cm 0.0001pt;"><span
lang="EN-GB"> </span></p>
<div style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-GB">The
algorithm is done twice (forward and backward).</span></div>
<div style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-GB"><br>
</span></div>
<div style="margin: 0cm 0cm 0.0001pt;"><span lang="EN-GB">Let us
know if it is something interesting for you. We will fix and
add tests and send you a pull request.</span></div>
<div><br class="webkit-block-placeholder">
</div>
<div>I have an aditional question: can you tell me where does
the autocomplete in <a moz-do-not-send="true"
href="http://graphhopper.com/maps">graphhopper.com/maps</a>
come from ?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>
<br class="Apple-interchange-newline">
<span style="color: rgb(0, 0, 0); font-family: Menlo;
font-size: 14px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px; display:
inline !important; float: none;">—pascal</span>
</div>
<br>
<div>
<div>Le 19 juin 2014 à 00:04, Bruno Carle <<a
moz-do-not-send="true" href="mailto:bruno.carle@gmail.com">bruno.carle@gmail.com</a>>
a écrit :</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div dir="ltr">Hi Petr,
<div>I agree, visiting and marking the edges sounds like a
better solution. But probably more complicated too
because of the 'islands' </div>
<div>Bruno</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Jun 18, 2014 at 6:11 PM,
Peter <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:graphhopper@gmx.de" target="_blank">graphhopper@gmx.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>Hey,<br>
<br>
maybe I don't understand the problem but why not
mark all visited nodes and remove the remaining?<br>
In the parking example an outgoingExplorer can
reach all its edges and won't help, but the second
step should be done with the ingoingExplorer and
will make those nodes none-explorable and so they
will be removed.<br>
<br>
Regards,<br>
Peter.<br>
<br>
</div>
<div>
<div class="h5">
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Hi,<br>
</div>
I can imagine a case like this: if a
parking consists of several edges, and is
connected to the rest of the graph thru a
one-way edge, the FixOneWayDeadEnds will
not detect it. (FixOneWayDeadEnds only
removes edge leading to a point without
way out/in )<br>
<br>
</div>
<div>Maybe something like this happen in
your example<br>
</div>
<div><br>
</div>
Bruno<br>
<div><br>
<br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Wed, Jun 18,
2014 at 3:52 PM, Pascal DANEK <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:pdanek@kds.com"
target="_blank">pdanek@kds.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="margin:0 0 0 .8ex;border-left:1px
#ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hi
Bruno,
<div><br>
</div>
<div>I updated my version of
Graphhopper, updated your code and
it now works as expected for
Edimbourg and many others, anyway
the algorithm. </div>
<div><br>
</div>
<div>However, it still fails for
some. </div>
<div><br>
</div>
<div>For example: <a
moz-do-not-send="true"
href="http://www.graphhopper.com/maps/?point=55.862711%2C-4.432372&point=55.864237%2C-4.251806&locale=fr-fr"
target="_blank">http://www.graphhopper.com/maps/?point=55.862711%2C-4.432372&point=55.864237%2C-4.251806&locale=fr-fr</a><br>
<div><br>
</div>
<div>It looks like the parking,
which is only accessible in one
way has not been removed. Any idea
why ?</div>
<div> <br>
<span style="font-family: Menlo;
font-size: 14px; font-style:
normal; font-variant: normal;
font-weight: normal;
letter-spacing: normal;
line-height: normal; text-align:
start; text-indent: 0px;
text-transform: none;
white-space: normal;
word-spacing: 0px; float: none;
display: inline !important;">—pascal</span>
</div>
<br>
<div>
<div>Le 18 juin 2014 à 10:58,
Bruno Carle <<a
moz-do-not-send="true"
href="mailto:bruno.carle@gmail.com"
target="_blank">bruno.carle@gmail.com</a>>
a écrit :</div>
<div>
<div><br>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Hi again Pascal,<br>
</div>
Please try with
astar/astarbi
algorithms, as I have
not tested with others.<br>
</div>
<div>Bruno<br>
</div>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On
Wed, Jun 18, 2014 at
10:17 AM, Bruno Carle <span
dir="ltr"><<a
moz-do-not-send="true"
href="mailto:bruno.carle@gmail.com" target="_blank">bruno.carle@gmail.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0 0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
<div dir="ltr">
<div>Hi Pascal,<br>
I downloaded
great-britain-latest.osm.pbf
from geofabrik and
tried your
Edinburg example
and it works fine
for me.<br>
</div>
<div>Do you have
more than one
encoder? If yes
please check that
the
directionBitMask
are correct.<br>
</div>
<div>Otherwise I can
not think right
now of something
else...<br>
</div>
<div>Cheers<span><font
color="#888888"><br>
Bruno<br>
</font></span></div>
</div>
<div>
<div>
<div
class="gmail_extra">
<br>
<br>
<div
class="gmail_quote">On
Tue, Jun 17,
2014 at 11:27
PM, Pascal
DANEK <span
dir="ltr"><<a
moz-do-not-send="true" href="mailto:pdanek@kds.com" target="_blank">pdanek@kds.com</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0
0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
<div
style="word-wrap:break-word">Hi
Bruno and
thanks a lot
for sharing,
<div><br>
</div>
<div>However
it does not
work as
expected on my
side. I can
see all logs
saying it
removes nodes,
but it still
not works. For
example:</div>
<div><br>
</div>
<div><a
moz-do-not-send="true"
href="http://graphhopper.com/maps/?point=55.948091%2C-3.36423&point=55.953252%2C-3.188267"
target="_blank">http://graphhopper.com/maps/?point=55.948091%2C-3.36423&point=55.953252%2C-3.188267</a></div>
<div><br>
</div>
<div>I guess
the Edimbourg
drop-off
should be
removed…</div>
<div><br>
</div>
<div>or: <a
moz-do-not-send="true"
href="http://graphhopper.com/maps/?point=nice&point=saint%20paul%20de%20vence"
target="_blank">http://graphhopper.com/maps/?point=nice&point=saint%20paul%20de%20vence</a></div>
<div><br>
</div>
<div>Does it
work for you ?</div>
<div><br>
</div>
<div>
<div><span
style="font-family:Menlo;font-size:14px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">—pascal</span>
</div>
<br>
<div>
<div>Le 17
juin 2014 à
16:32, Bruno
Carle <<a
moz-do-not-send="true"
href="mailto:bruno.carle@gmail.com" target="_blank">bruno.carle@gmail.com</a>>
a écrit :</div>
<div><br>
<blockquote
type="cite">
<div dir="ltr">
<div> Hi,<br>
</div>
<div>I just
wrote a small
class that
fixes this
kind of
issues.
Basically it
looks for
nodes where
there is a way
in but not out
(and
vice-versa),
and disable
all edges
around the
node. It seems
to work fine
so far. I
Think islands
will not be a
problem but I
have not
tested it
since I don't
have any
islands on the
area I am
working on.<br>
<br>
</div>
<div>For cases
when there is
no way out but
there is a way
in, I believe
most likely it
is a problem
on the map.<br>
</div>
<div>For cases
when there is
no way in but
a way out , I
believe the
map is
correct: e.g.
<a
moz-do-not-send="true"
href="http://www.openstreetmap.org/way/27565747" target="_blank">http://www.openstreetmap.org/way/27565747</a>,
and hence this
should be
addressed in
GH.<br>
<br>
</div>
<div>This is
how to call
it: (if you
have multiple
encoders you
ll need a way
to retrieve
the encoder's
directionBitMask)<br>
</div>
<div><br>
</div>
<div>@Override<br>
</div>
<div>public
GraphHopper
importOrLoad(){<br>
super.importOrLoad();<br>
FixOneWayDeadEnds.fixAllOneWayDeadEnds(this.getGraph(),getEncodingManager().getSingle(),3l);<br>
</div>
<div>
return this;<br>
</div>
<div>}<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>Cheers<br>
</div>
<div>Bruno<br>
</div>
<div><br>
<br>
<br>
<br>
</div>
</div>
<div
class="gmail_extra"><br>
<br>
<div
class="gmail_quote">On
Mon, Jun 16,
2014 at 9:52
PM,
graphhopper <span
dir="ltr"><<a
moz-do-not-send="true" href="mailto:graphhopper@gmx.de" target="_blank">graphhopper@gmx.de</a>></span>
wrote:<br>
<blockquote
class="gmail_quote"
style="margin:0
0 0
.8ex;border-left:1px
#ccc
solid;padding-left:1ex">
<div
bgcolor="#FFFFFF"
text="#000000">
<div>Yeah this
is a frequent
requested
feature but
not hard to
implement:<br>
<a
moz-do-not-send="true"
href="http://graphhopper-read-only-archive.1087335.n5.nabble.com/Issues-detecting-driving-paths-along-one-way-streets-td1002.html#a1003"
target="_blank">http://graphhopper-read-only-archive.1087335.n5.nabble.com/Issues-detecting-driving-paths-along-one-way-streets-td1002.html#a1003</a><br>
<br>
But this would
mean hiding
the real OSM
issues ...<br>
<br>
Regards,<br>
Peter.<br>
<br>
</div>
<div>
<blockquote
type="cite">
Hi Peter,
<div><br>
</div>
<div>We played
with the
settings
(minNetworkSize
and
highResolution)
and it solved
a certain
class of
problems.
However, most
of the
requests still
fail. After
deeper
investigation,
we discovered
it is due to
one of the two
points using a
way which is a
oneway,
leading to a
subnetwork
from which you
can’t return.
It occurs in
many airports
or within
private areas.</div>
<div><br>
</div>
<div>I think
it is a bug in
data, but
despite of
this, I
believe
Graphhopper
should manage
that properly
in order to
make it really
useable. (osrm
has the same
issue). I
mean, we have
thousands of
requests which
fail.</div>
<div><br>
</div>
<div>What we
did for now:
We implemented
in the web
service an
option
specifying
that the
service, in
case of a “not
found”, move
start or
destination
point
(alternatively)
within a
certain
distance,
until it finds
a route. This
actually solve
the problem by
making the
routing
service using
a routable
way. Are you
interested by
this patch ?</div>
<div><br>
</div>
<div>Of
course, it is
only a
workaround,
maybe not
suitable for a
long term
solution. We
think that a
correct way to
fix this would
be to clean
the graph, at
the prepare
stage,
removing nodes
after a one
way if they
are less than
N. What do you
think about
this ?</div>
<div><br>
</div>
<div>
<div><span
style="font-family:Menlo;font-size:14px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">—pascal</span>
</div>
<br>
<div>
<div>Le 2 juin
2014 à 10:48,
Peter K <<a
moz-do-not-send="true" href="mailto:peathal@yahoo.de" target="_blank">peathal@yahoo.de</a>>
a écrit :</div>
<br>
<blockquote
type="cite">
<div
bgcolor="#FFFFFF"
text="#000000">
<div>Hey
Pascal,<br>
<br>
there are
cases with
oneway where
it wouldn't be
logical to
return a
route. Still
there are
workarounds
like described
here:<br>
<a
moz-do-not-send="true"
href="https://lists.openstreetmap.org/pipermail/graphhopper/2014-May/000960.html"
target="_blank">https://lists.openstreetmap.org/pipermail/graphhopper/2014-May/000960.html</a><br>
<br>
But in your
case it is a
mapping
problem with
the incorrect
oneway
somewhere
here:<br>
<a
moz-do-not-send="true"
href="http://graphhopper.com/maps/?point=43.697867%2C7.121721&point=43.69784%2C7.121657"
target="_blank">http://graphhopper.com/maps/?point=43.697867%2C7.121721&point=43.69784%2C7.121657</a><br>
<br>
which makes
the whole
district in
the south
unavailable.<br>
<br>
Regards,<br>
Peter.<br>
<br>
<br>
</div>
<blockquote
type="cite">
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas">Hello folks,</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas"><br>
</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas">I am Pascal and I currently evaluate Graphhopper as an
alternative
routing
service for my
company.</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas"><br>
</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas">We are currently facing an issue with an itinerary: from
“Nice" to “St
Paul de
vence”, we
just get a
“not found”
response from
GH.</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas"><br>
</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas">I tested the official online instance and I get the same
behaviour:</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><a
moz-do-not-send="true"
href="http://maps.ad-kds.lan.net:8900/?point=43.703002,7.265224&point=43.694687,7.124634&locale=fr-FR"
style="color:purple" target="_blank"><font face="Consolas">http://graphhopper.com/maps/?point=nice%20&point=saint%20paul%20de%20vence</font></a></div>
<p
class="MsoNormal"
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas"> </font></p>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas">Whereas the opposite works fine:</font></div>
<div
style="margin:0cm
0cm 0.0001pt"><font
face="Consolas"><a moz-do-not-send="true"
href="http://graphhopper.com/maps/?point=saint%20paul%20de%20vence&point=nice"
target="_blank">http://graphhopper.com/maps/?point=saint%20paul%20de%20vence&point=nice</a></font></div>
<div><font
face="Consolas"><br>
</font></div>
<div> <font
face="Consolas">Is
it a bug
related to
some kind of
one way
direction ?</font></div>
<div><font
face="Consolas"><br>
</font></div>
<div><font
face="Consolas">Should
I submit a
bug, or do I
miss something
?</font></div>
<div><font
face="Consolas"><br>
</font></div>
<div><font
face="Consolas">Thanks
in advance for
your help,</font></div>
<div><font
face="Consolas"><br>
<span
style="font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">—pascal</span></font></div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>