<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">ok, you are probably right that if it
is explicitelyt tagged it should be passable. I've reopened the
issue:<br>
<a class="moz-txt-link-freetext" href="https://github.com/graphhopper/graphhopper/issues/407">https://github.com/graphhopper/graphhopper/issues/407</a><br>
<br>
Would you comment on it and tell e.g. the area where this is the
case?<br>
<br>
Peter<br>
<br>
On 19.05.2015 09:39, XCTrails wrote:<br>
</div>
<blockquote
cite="mid:CAMt9zrs4jvSTXXu2qAbYQJeg5BQFDyrtLEE=cVouDJiTtu4Kfw@mail.gmail.com"
type="cite">
<div dir="ltr">Hi,<br>
<br>
<div>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div> we have indeed marked some barriers as
'absolute' barriers where even a tagging won't help
I think:<br>
<a moz-do-not-send="true"
href="https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/routing/util/BikeCommonFlagEncoder.java#L84"
target="_blank">https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/routing/util/BikeCommonFlagEncoder.java#L84</a><br>
<br>
Please create an issue for this if you think this
should be improved.<br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I just saw that this was changed, great. However, I'm
not quite sure if I interpret the code correctly, but
doesn't <span class=""
title="core/src/test/java/com/graphhopper/routing/util/BikeFlagEncoderTest.java">BikeFlagEncoder
still block </span>a kissing_gate even if there's a
bicycle=true flag? <br>
<br>
<span class=""
title="core/src/test/java/com/graphhopper/routing/util/BikeFlagEncoderTest.java">BikeFlagEncoderTest.java:<br>
<br>
// kissing_gate with bicycle tag<br>
node = new OSMNode(1, -1, -1);<br>
node.setTag("barrier", "kissing_gate");<br>
node.setTag("bicycle", "yes");<br>
// barrier! <br>
assertFalse(encoder.handleNodeTags(node) == 0);<br>
<br>
</span></div>
<div><span class=""
title="core/src/test/java/com/graphhopper/routing/util/BikeFlagEncoderTest.java">If
my interpretation is correct, I think that
implementation is wrong. In our parts of the world, we
have plenty of kissing_gates and turnstiles, which
primarily block cows and maybe cars but not bikes,
regardless of type. Hence the bicycle=yes tag...<br>
<br>
</span></div>
<div><span class=""
title="core/src/test/java/com/graphhopper/routing/util/BikeFlagEncoderTest.java">cheers,<br>
</span></div>
<div><span class=""
title="core/src/test/java/com/graphhopper/routing/util/BikeFlagEncoderTest.java">Armin<br>
<br>
</span></div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
GraphHopper mailing list
<a class="moz-txt-link-abbreviated" href="mailto:GraphHopper@openstreetmap.org">GraphHopper@openstreetmap.org</a>
<a class="moz-txt-link-freetext" href="https://lists.openstreetmap.org/listinfo/graphhopper">https://lists.openstreetmap.org/listinfo/graphhopper</a>
</pre>
</blockquote>
<br>
</body>
</html>