<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hello ratrun</div><div><br></div><div>I can understand the usage of a small amount of flags however I would have thought logic more akin to the following. This would only highlight something as a cycleway if it is intentionally marked as such rather than merely having a right of way.</div><div><br></div><div>Edited in the email so apologies for any formatting issues.</div><div><br></div><div>if (way.hasTag("bicycle", intendedValues))</div><div>{</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>if(isPushingSection)</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>wayType = WayType.OTHER_SMALL_WAY</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>else if (“cycleway”.equals(highway)) </div><div><span class="Apple-tab-span" style="white-space:pre"> </span>wayType = WayType.CYCLEWAY;</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>else if (way.hasTag(“bicycle”,”designated) </div><div> <span class="Apple-tab-span" style="white-space:pre"> </span>wayType = WayType.CYCLEWAY;</div><div> <span class="Apple-tab-span" style="white-space:pre"> </span>else if (roadValues.contains(highway))</div><div><span class="Apple-tab-span" style="white-space: pre;"> </span>wayType = WayType.ROAD;</div><span class="Apple-tab-span" style="white-space: pre;"> </span><div><br></div><div>Any thoughts?</div><div><br></div><div>Sincerely</div><div>Stuart Adam<br><div><br><div><br><div><div>On 2 Jun 2015, at 16:10, ratrun <<a href="mailto:ratrun@gmx.at">ratrun@gmx.at</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hello Stuart,<br><br>the waytype information is just used for the routing instructions such that a cycle rider gets a better idea what kind of way to look at. As the bits are limited and a more exact infomration is superflous for that purpose, I intentionally mangled all kind of ways somehow marked for bicycle usage together into "CYCLEWAY".<br><br>I also had some code which produced a statistic of the tour. It calcualted the distances per each paved and unpaved waytype. This code didn't make it into the master, although I think that it is an important feature for bicycle routing. The problem was that the code was too bicycle specific and required changes in all other flag encoders as well - see issue #209.<br><br>ratrun<br><br><div class="moz-cite-prefix">Am 02.06.2015 um 16:17 schrieb Stuart Adam:<br></div><blockquote cite="mid:DUB119-W31E25F0C89FC01BFC0B90FBAB50@phx.gbl" type="cite"><div dir="ltr">Hello all<br><br>I am starting to look at bike routing and I note in the handleBikeRelated method in BikeCommonFlagEncoder the following logic applies.<br><br> if (way.hasTag("bicycle", intendedValues))<br> <span class="Apple-converted-space"> </span>{<br> <span class="Apple-converted-space"> </span>if (isPusingSection && !way.hasTag("bicycle", "designated"))<br> <span class="Apple-converted-space"> </span>wayType = WayType.OTHER_SMALL_WAY;<br> <span class="Apple-converted-space"> </span>else<br> <span class="Apple-converted-space"> </span>wayType = WayType.CYCLEWAY;<br> <span class="Apple-converted-space"> </span>} else if ("cycleway".equals(highway))<br> <span class="Apple-converted-space"> </span>wayType = WayType.CYCLEWAY;<br> <span class="Apple-converted-space"> </span>else if (roadValues.contains(highway))<br> <span class="Apple-converted-space"> </span>wayType = WayType.ROAD;<br><br><br>This does not seem correct to me as from my understanding this is taking the fact that a way has been marked as having a right of way for bicycles (but not a pushing section) then it is a full blown cyclepath. In my mind at least cycleway implies dedicated and marked (normally with differently coloured tarmac) sections which is a much stronger indication for cycle use than just a bicycle right of way.<br><br><br>Am I correct and if so should this be changed or was there a reason for this decision in Graphhopper.<br><br>Sincerely<br>Stuart Adam<br></div><br><fieldset class="mimeAttachmentHeader"></fieldset><br><pre wrap="">_______________________________________________
GraphHopper mailing list
<a class="moz-txt-link-abbreviated" href="mailto:GraphHopper@openstreetmap.org">GraphHopper@openstreetmap.org</a>
<a class="moz-txt-link-freetext" href="https://lists.openstreetmap.org/listinfo/graphhopper">https://lists.openstreetmap.org/listinfo/graphhopper</a>
</pre></blockquote><br>_______________________________________________<br>GraphHopper mailing list<br><a href="mailto:GraphHopper@openstreetmap.org">GraphHopper@openstreetmap.org</a><br><a href="https://lists.openstreetmap.org/listinfo/graphhopper">https://lists.openstreetmap.org/listinfo/graphhopper</a><br></div></blockquote></div><br></div></div></div></body></html>