<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hello Peter<div><br></div><div>I don’t have a unit test yet I will see if there is something I can put together. The reason for this is I am working on an alternate (i.e. non ism xml) datasource and it encodes road types and right of way information. This means that a road can be marked as having bicycle right of way yes but not designated as the uk rights of way are not generally that specific. It may be worth taking into account </div><div><br></div><div><a href="http://wiki.openstreetmap.org/wiki/United_Kingdom_Tagging_Guidelines">http://wiki.openstreetmap.org/wiki/United_Kingdom_Tagging_Guidelines</a></div><div><br></div><div>Which has two approaches :-</div><div> 1) classic which merely tags at the historical right of way name level</div><div> 2) alternative which tags the individual access rights given by the traditional right of way. so a bridleway could lead to tags of </div><div><br></div><div><tt style="background:#DDE;white-space:nowrap" dir="ltr">h<a href="http://wiki.openstreetmap.org/wiki/Key:highway" title="Key:highway">ighway</a>=<a href="http://wiki.openstreetmap.org/wiki/Tag:highway%3Dpath" title="Tag:highway=path">path</a></tt>;<br><tt style="background:#DDE;white-space:nowrap" dir="ltr"><a href="http://wiki.openstreetmap.org/wiki/Key:horse" title="Key:horse">horse</a>=<a href="http://wiki.openstreetmap.org/wiki/Tag:horse%3Ddesignated" title="Tag:horse=designated" class="mw-redirect">designated</a></tt>;<br><tt style="background:#DDE;white-space:nowrap" dir="ltr"><a href="http://wiki.openstreetmap.org/wiki/Key:bicycle" title="Key:bicycle">bicycle</a>=<a href="http://wiki.openstreetmap.org/wiki/Tag:bicycle%3Dyes" title="Tag:bicycle=yes" class="mw-redirect">yes</a></tt>†;<br><tt style="background:#DDE;white-space:nowrap" dir="ltr"><a href="http://wiki.openstreetmap.org/wiki/Key:foot" title="Key:foot">foot</a>=<a href="http://wiki.openstreetmap.org/wiki/Tag:foot%3Ddesignated" title="Tag:foot=designated" class="mw-redirect">designated</a></tt></div><div><br></div><div>Given the separate dataset origin and the fact this is not yet part of upstream I will try and write an osm centric unit test.</div><div><br></div><div>Sincerely</div><div>Stuart Adam</div><div><br></div><div><br><div><div>On 2 Jun 2015, at 15:23, Peter <<a href="mailto:graphhopper@gmx.de">graphhopper@gmx.de</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class="moz-cite-prefix">Hi Stuart,<br><br>do you have a simple unit test where it shows for which tagging you expect a different behaviour?<br><br>Maybe this is related to:<br><a class="moz-txt-link-freetext" href="https://github.com/graphhopper/graphhopper/pull/421">https://github.com/graphhopper/graphhopper/pull/421</a><span class="Apple-converted-space"> </span>?<br><br>Regards,<br>Peter<br><br>On 02.06.2015 16:17, Stuart Adam wrote:<br></div><blockquote cite="mid:DUB119-W31E25F0C89FC01BFC0B90FBAB50@phx.gbl" type="cite"><div dir="ltr">Hello all<br><br>I am starting to look at bike routing and I note in the handleBikeRelated method in BikeCommonFlagEncoder the following logic applies.<br><br> if (way.hasTag("bicycle", intendedValues))<br> {<br> if (isPusingSection && !way.hasTag("bicycle", "designated"))<br> wayType = WayType.OTHER_SMALL_WAY;<br> else<br> wayType = WayType.CYCLEWAY;<br> } else if ("cycleway".equals(highway))<br> wayType = WayType.CYCLEWAY;<br> else if (roadValues.contains(highway))<br> wayType = WayType.ROAD;<br><br><br>This does not seem correct to me as from my understanding this is taking the fact that a way has been marked as having a right of way for bicycles (but not a pushing section) then it is a full blown cyclepath. In my mind at least cycleway implies dedicated and marked (normally with differently coloured tarmac) sections which is a much stronger indication for cycle use than just a bicycle right of way.<br><br><br>Am I correct and if so should this be changed or was there a reason for this decision in Graphhopper.<br><br>Sincerely<br>Stuart Adam<br></div><br><fieldset class="mimeAttachmentHeader"></fieldset><br><pre wrap="">_______________________________________________
GraphHopper mailing list
<a class="moz-txt-link-abbreviated" href="mailto:GraphHopper@openstreetmap.org">GraphHopper@openstreetmap.org</a>
<a class="moz-txt-link-freetext" href="https://lists.openstreetmap.org/listinfo/graphhopper">https://lists.openstreetmap.org/listinfo/graphhopper</a>
</pre></blockquote><br>_______________________________________________<br>GraphHopper mailing list<br><a href="mailto:GraphHopper@openstreetmap.org">GraphHopper@openstreetmap.org</a><br><a href="https://lists.openstreetmap.org/listinfo/graphhopper">https://lists.openstreetmap.org/listinfo/graphhopper</a><br></div></blockquote></div><br></div></body></html>