<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<div>Thanks for doing the review!<br></div><div><br></div><div>I think that including sheds is ok</div><div>if dataset is trustworthy.<br></div><div><br></div><div>Based on this description quality</div><div>seems sufficient, at least I would support</div><div>such import in my area.</div><div><br></div><div>Have you checked whether there are</div><div>mapped buildings with lifecycle prefixes</div><div>in your area?</div><div><br></div><div><br></div><div><br></div><div>5 Feb 2021, 00:20 by imports@openstreetmap.org:<br></div><blockquote class="tutanota_quote" style="border-left: 1px solid #93A3B8; padding-left: 10px; margin-left: 5px;"><div>I've updated the wiki page to reflect those changeset tags, thank you<br></div><div>for pointing that out. <br></div><div><br></div><div>Just finished reviewing the data quality of this sample. There are<br></div><div>about 1200 building footprints present. Buildings I'm familiar with<br></div><div>represent the ground situation, and there are no glaring<br></div><div>inconsistencies. Checking against satellite imagery (Bing as of 2021),<br></div><div>all footprints are over buildings and in good alignment (not rotated).<br></div><div>Larger buildings have about a 1-2 foot offset, as well as most smaller<br></div><div>houses. There are portions where houses have between 3-5 foot offset,<br></div><div>appearing under tree cover. Against Google and ESRI Imagery World<br></div><div>satellite all buildings are offset ~15 feet southeast.<br></div><div><br></div><div>I also found 12 buildings which will need to be manually updated for<br></div><div>what appear to be additions. No footprints appear to have more than 10<br></div><div>vertices in their polygons, except those with rounded corners. The JOSM<br></div><div>validator found no errors. Can't confirm that all "sheds" in the<br></div><div>backyards of homes exist. Perhaps they should be considered temporary<br></div><div>buildings and filtered out to prevent clutter. <br></div><div><br></div><div>I have a script comparing the centroid coordinates for individual<br></div><div>buildings appearing in both OpenStreetMap and the prepared file for the<br></div><div>whole county. When selecting buildings whose area was less than 5%<br></div><div>different, there was a 4 foot difference on average. I will refine this<br></div><div>script and put it in the repository later.<br></div><div><br></div><div>Does this sample file meet the quality required for import in<br></div><div>OpenStreetMap? <br></div><div><br></div><div>Jack<br></div><div><br></div><div>On Thu, 2021-02-04 at 18:44 +0100, Mateusz Konieczny via Imports wrote:<br></div><blockquote><div>Yes, that seems fine to me.<br></div><div><br></div><div>And for initial edits made by bot process and still fully reviewed<br></div><div>bot=yes is not so necessary.<br></div><div><br></div><div>The most important part is including documentation page so<br></div><div>for example 5 years later someone will be able to easily confirm<br></div><div>that it is a legitimate import - and find full detail.<br></div><div><br></div><div>BTW, have you reviewed data quality on same sample?<br></div><div>Is it matching on the ground situation or at least aerials?<br></div><div><br></div><div>Looking at<br></div><div>https://gitlab.com/jackarnold/onondaga-building-osm-import/-/blob/master/prepare.py#L56<br></div><div>Is in area of import something like demolished:building=yes?<br></div><div>Or maybe someone used other<br></div><div>https://wiki.openstreetmap.org/wiki/Lifecycle_prefix ?<br></div><div>https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dstorage_tank <br></div><div>appearing in dataset as a building?<br></div><div><br></div><div>Is dataset including fully underground features (location=undeground,<br></div><div>maybe also layer tag needed)?<br></div><div><br></div><div>Feb 4, 2021, 18:11 by imports@openstreetmap.org:<br></div><div>> I plan on starting by manually reviewing and uploading changesets,<br></div><div>> so I<br></div><div>> didn't feel pointing out it was automated necessary. It was poorly<br></div><div>> phrased. Would this be appropriate for changeset tags?<br></div><div>> <br></div><div>> comment=Onondaga County, NY building footprints import<br></div><div>> https://wiki.openstreetmap.org/wiki/Import/Catalogue/Onondaga_County_NY_Building_Footprint_Import<br></div><div>> bot=yes<br></div><div>> source=http://www.fsihost.com/onondaga/<br></div><div>> source:date=2020-10-01<br></div><div>> <br></div><div>> On Thu, 2021-02-04 at 11:56 +0100, Mateusz Konieczny via Imports<br></div><div>> wrote:<br></div><div>> > "Changeset tags won't be necessary until the import is automated<br></div><div>> > and<br></div><div>> > not manually reviewed."<br></div><div>> > <br></div><div>> > https://wiki.openstreetmap.org/wiki/Import/Catalogue/Onondaga_County_NY_Building_Footprint_Import<br></div><div>> > <br></div><div>> > What you mean by that?<br></div><div>> > Changeset tags should at least link wiki documentation page and<br></div><div>> > mark it as a bot edit (though wiki documentation page may be also<br></div><div>> > linked in<br></div><div>> > the changeset comment).<br></div><div>> > <br></div><div>> > Feb 4, 2021, 01:55 by imports@openstreetmap.org:<br></div><div>> > > Hello,<br></div><div>> > > <br></div><div>> > > I previously discussed importing building footprints for<br></div><div>> > > Onondaga<br></div><div>> > > County, NY from data provided by the Syracuse-Onondaga County<br></div><div>> > > Planning<br></div><div>> > > Agency. The data source was prepared for the county by<br></div><div>> > > “Pictometry<br></div><div>> > > International using digital orthogonal<br></div><div>> > > aerial photography flown by Pictometry”. The data have been<br></div><div>> > > updated<br></div><div>> > > as<br></div><div>> > > recently as October 2020 and not since, after checking with<br></div><div>> > > SOCPA.<br></div><div>> > > It<br></div><div>> > > is accurate to between 2 and 5 feet when compared against Bing<br></div><div>> > > Imagery<br></div><div>> > > or ESRI World Imagery. SOCPA has given OpenStreetMap a waiver<br></div><div>> > > to<br></div><div>> > > use<br></div><div>> > > this data, which has been verified by the legal team on their<br></div><div>> > > mailing<br></div><div>> > > list.<br></div><div>> > > <br></div><div>> > > Recently I’ve been working on formalizing the conversion script<br></div><div>> > > and<br></div><div>> > > wiki page, which is available here:<br></div><div>> > > <br></div><div>> > > https://wiki.openstreetmap.org/wiki/Import/Catalogue/Onondaga_County_NY_Building_Footprint_Import<br></div><div>> > > <br></div><div>> > > To allow the community to review the import at this state, I<br></div><div>> > > have<br></div><div>> > > created a shapefile from converted data for the Village of<br></div><div>> > > Liverpool,<br></div><div>> > > NY:<br></div><div>> > > <br></div><div>> > > https://gitlab.com/jackarnold/onondaga-building-osm-import-example/-/raw/master/20210203/28_Village%20of%20Liverpool.geojson<br></div><div>> > > <br></div><div>> > > I hope that there will be no issues with the data, and minimal<br></div><div>> > > tweaking<br></div><div>> > > to be required to move forward with the import. From here I<br></div><div>> > > will<br></div><div>> > > manually verify the data against satellite imagery, then upload<br></div><div>> > > the<br></div><div>> > > OSM<br></div><div>> > > file to the test server, and verify it once again. With<br></div><div>> > > approval<br></div><div>> > > from<br></div><div>> > > the community, I will continue to import one<br></div><div>> > > municipality/town/or<br></div><div>> > > smaller boundary at a time on the main server, and update the<br></div><div>> > > wiki<br></div><div>> > > page<br></div><div>> > > with my progress.<br></div><div>> > > <br></div><div>> > > I would appreciate and comments, suggestions, or concerns!<br></div><div>> > > <br></div><div>> > > Thanks,<br></div><div>> > > Jack<br></div><div>> > > <br></div><div>> > > <br></div><div>> > > _______________________________________________<br></div><div>> > > Imports mailing list<br></div><div>> > > Imports@openstreetmap.org<br></div><div>> > > https://lists.openstreetmap.org/listinfo/imports<br></div><div>> > <br></div><div>> > _______________________________________________<br></div><div>> > Imports mailing list<br></div><div>> > Imports@openstreetmap.org<br></div><div>> > https://lists.openstreetmap.org/listinfo/imports<br></div><div>> <br></div><div>> <br></div><div>> <br></div><div>> <br></div><div>> _______________________________________________<br></div><div>> Imports mailing list<br></div><div>> Imports@openstreetmap.org<br></div><div>> https://lists.openstreetmap.org/listinfo/imports<br></div><div><br></div><div>_______________________________________________<br></div><div>Imports mailing list<br></div><div>Imports@openstreetmap.org<br></div><div>https://lists.openstreetmap.org/listinfo/imports<br></div></blockquote><div><br></div><div><br></div><div><br></div><div>_______________________________________________<br></div><div>Imports mailing list<br></div><div>Imports@openstreetmap.org<br></div><div>https://lists.openstreetmap.org/listinfo/imports<br></div></blockquote> </body>
</html>