<div dir="ltr"><div>OK I've run the JOSM validator and things look good. No addresses should be created within Santa Rosa city limits since those were imported previously. There are perhaps a handful of geometry or overlap or duplicate address validation errors per import file, however they are relatively easy to fix by hand and relatively hard to fix automatically.<br></div><div><br></div><div>Here's my spot check notes:<br></div><div><br></div><div>buildings_1044:</div><div>- one malformed building that has a way segment twice (easily fixed)</div><div>- about a dozen buildings intersecting highways (misaligned highways)</div><div>- two pairs of duplicate house number (parcel addresses are also duplicated)<br></div><div><br></div><div>buildings_1008:<br>- one malformed apartment relation that needs manual fixing anyway: missed because it wasn't a building and only detected because it's already duplicated in OSM<br>- two newly inserted buildings intersecting way, but it's the way's fault and easily fixed<br><br>buildings_966:<br>- one new building crossing a landuse<br>- two new buildings crossing a waterway (tunnel? misaligned culvert?)<br>- one new building pair that duplicates each other's address, usually because it's two parcels with the same address (easily manually fixed)<br><br>buildings_977:<br>- five sheds that incorrectly intersect a preexisting fence (not a lot of margin for error on these lots)<br>- two buildings intersecting highway (misaligned existing roads)<br>- building intersecting highway area (misaligned area)<br>- bus stop intersecting sidewalk (easily fixable)<br>- 8 duplicate pairs of house numbers (again seems like a minor parcel labeling issue)</div><div><br></div><div>I'm feeling quite good about this data. We won't be importing 100% of the available data (I'm not touching existing addresses or existing buildings even though I could try) but the data we are importing should be quite useful and accurate.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 28, 2021 at 1:49 PM zyphlar <<a href="mailto:zyphlar@gmail.com" target="_blank">zyphlar@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I'll add to the wiki a description of the conflation process. As you can see from the scripts, conflation is a major portion of the process and we will not be importing or modifying any existing buildings. I have seen a rare case where perhaps a polygon is planned to be imported on top of an existing building which I think may be an artifact of the county using multipolygons for courtyards and architectural features; since the actual import will be divided into manual tasks and these instances seem rare I'm not very worried about it. As you can see from the screenshots in Github, the detection seems pretty reliable.</div><div><br></div><div>If you load up the OSM file you can see that often the imported data will be even more high-fidelity than existing buildings, and the address data seems quite good with only understandable mistakes for example at street corners where perhaps a business owner has bought multiple lots and perhaps chosen to advertise one address over another (which we can't know from our armchairs), or buildings which span multiple parcels that can confuse the conflation logic (in which case I've noticed we generally avoid assigning an address at all rather than be incorrect). Still, the logic seems very good and my spot checking has been pretty extensive: even if there's some mistakes here and there, this data will greatly improve OSM's local usability.</div><div><br></div><div>I have opened these files in JOSM, but I have not yet run the validator on them, will do.</div><div><br></div><div>Once I am done debugging and the data looks good I'll remove the x_son tags, that's been noted in my TODOs.</div><div><br></div><div>Finally, I just went ahead and used the `usecode` data to assign building types when possible. I'll have that update ready for review shortly, and be spot checking it myself.</div><div><br></div><div>Thanks for your feedback!<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 28, 2021 at 1:28 PM Mateusz Konieczny via Imports <<a href="mailto:imports@openstreetmap.org" target="_blank">imports@openstreetmap.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div>In general thanks for making import! It takes plenty of time but if done well<br></div><div>can allow to avoid spending mapping time on something already mapped<br></div><div>and to avoid drudgery of mapping buildings from aerial imagery.<br></div><div><br></div><div>------------------------------------------------------------------------------------<br></div><div><br></div><div>ref:database_code=object_code is something that I deeply dislike, so personally <br></div><div>I would remove it unless absolutely necessary.<br></div><div><br></div><div>It is confusing, not human readable, and sometimes scares/confuses newbies.<br></div><div><br></div><div>In most cases is never used or trusted too much if ever used.<br></div><div><br></div><div>Though it was used in many import and noone died from it and I am not a local mapper,<br></div><div>so treat it as a suggestion/opinion.<br></div><div><br></div><div>------------------------------------------------------------------------------------<br></div><div><br></div><div>source=* tag definitely goes on changeset, not on every edited object<br></div><div><br></div><div>------------------------------------------------------------------------------------<br></div><div><br></div><div>Have you tried opening upload files, downloading existing data and running JOSM validator? <br></div><div><br></div><div>------------------------------------------------------------------------------------<br></div><div><br></div><div>Wiki page does not mention explicitly that duplicating already existing building data<br></div><div>(conflation) is done, hopefully it is just missing from wiki page.<br></div><div><br></div><div>------------------------------------------------------------------------------------<br></div><div><br></div><div>Have you checked whether building quality in that dataset is good enough for importing?<br></div><div><br></div><div>Apr 28, 2021, 21:11 by <a href="mailto:zyphlar@gmail.com" target="_blank">zyphlar@gmail.com</a>:<br></div><blockquote style="border-left:1px solid rgb(147,163,184);padding-left:10px;margin-left:5px"><div dir="ltr"><div>Absolutely, great suggestions, I've updated the wiki and license.<br></div><div><br></div><div>I was planning to remove the x_son_p tags before final import as they are mostly useful for debugging, however if you think it's useful to keep database foreign keys like GID, or I also have a parcel use code available that may correlate to building type (either parseable now during import or perhaps in the future), I can leave one or both in. If there's no other major task remaining maybe I can put energy into correlating usecodes with OSM building types and then leave the x_son data completely out.<br></div><div><br></div><div>Question, some imports seem to attach a source tag to every item they import, which seems excessive to me. Maybe I can just mark the source in the changesets?<br></div></div><div><br></div><div><div dir="ltr">On Wed, Apr 28, 2021 at 6:22 AM Mateusz Konieczny via Imports <<a href="mailto:imports@openstreetmap.org" rel="noopener noreferrer" target="_blank">imports@openstreetmap.org</a>> wrote:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div>Can you add license to <a rel="noopener noreferrer" href="https://github.com/zyphlar/sonoma-import/" target="_blank">https://github.com/zyphlar/sonoma-import/</a> repository,<br></div><div>so that this code would be potentially reusable by someone else?<br></div><div><br></div><div><a rel="noopener noreferrer" href="https://wiki.openstreetmap.org/wiki/Sonoma_County_Building_and_Address_Import" target="_blank">https://wiki.openstreetmap.org/wiki/Sonoma_County_Building_and_Address_Import</a><br></div><div>is missing info which tags will be used.<br></div><div><br></div><div>For example in <br></div><div><a href="https://raw.githubusercontent.com/zyphlar/sonoma-import/main/out/clean/buildings_1000.osm" rel="noopener noreferrer" target="_blank">https://raw.githubusercontent.com/zyphlar/sonoma-import/main/out/clean/buildings_1000.osm</a><br></div><div>I see tags such as x_son_p:gid<br></div><div><br></div><div>Apr 28, 2021, 05:58 by <a href="mailto:zyphlar@gmail.com" rel="noopener noreferrer" target="_blank">zyphlar@gmail.com</a>:<br></div><blockquote style="border-left:1px solid rgb(147,163,184);padding-left:10px;margin-left:5px"><div dir="ltr"><div dir="ltr"><pre><div>Hi there!<br></div><div><br></div><div>I think I'm ready for a review and approval of building and address import for<br></div><div>Sonoma County California.
Please see: <a href="https://wiki.openstreetmap.org/wiki/Sonoma_County_Building_and_Address_Import" rel="noopener noreferrer" target="_blank">https://wiki.openstreetmap.org/wiki/Sonoma_County_Building_and_Address_Import</a><br></div><div>and: <a href="https://github.com/zyphlar/sonoma-import/" rel="noopener noreferrer" target="_blank">https://github.com/zyphlar/sonoma-import/</a><br></div><div>for status, details, and downloadable OSM files to preview the data.<br></div><div><br></div><div>Local community involvement has unfortunately been lackluster, but 1ec5 and impiaaa<br></div><div>have been invaluable in helping me get my first import together.<br></div></pre><pre>Any and all feedback is appreciated!<br></pre></div></div></blockquote><div><br></div></div><div>_______________________________________________<br></div><div> Imports mailing list<br></div><div> <a href="mailto:Imports@openstreetmap.org" rel="noopener noreferrer" target="_blank">Imports@openstreetmap.org</a><br></div><div> <a rel="noopener noreferrer" href="https://lists.openstreetmap.org/listinfo/imports" target="_blank">https://lists.openstreetmap.org/listinfo/imports</a><br></div></blockquote></div></blockquote><div><br></div> </div>
_______________________________________________<br>
Imports mailing list<br>
<a href="mailto:Imports@openstreetmap.org" target="_blank">Imports@openstreetmap.org</a><br>
<a href="https://lists.openstreetmap.org/listinfo/imports" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/imports</a><br>
</blockquote></div>
</blockquote></div>