[josm-dev] Audio mapping Plugin
frederik at remote.org
Fri Feb 1 13:12:20 GMT 2008
> I've recently seen that there is a package markerlayer which resambles
> this, and it already has ImageMarker and AudioMarker.
The idea behind the marker layer is that it can have any number of
markers placed anywhere on the map and these may take user input (mostly
clicking). The marker layer is (exclusively ATM) created from <wpt> tags
in the GPX file.
> But GeoImageLayer
> has nothing to do with this, has it?
No, although they do share functionality; GeoImageLayer could probably
dropped and its functionality (displaying images when you click on the
camera symbol) could be modelled in an ImageMarker.
> Is there any policy to put together the
> geoXxxLayers with MarkerLayer, or are this two very different things?
When I created the MarkerLayer I didn't want to change everything that
was already there but with hindsight it seems reasonable to merge the
GeoImage and the Marker stuff.
Your application is quite different though as it requires a kind of
"linear" feature (not only markers) and is likely to produce animations
as well (with a cursor moving in sync with the sound playback or so). So
that would surely be beyond what the marker layer was made for. Doesn't
mean you can't extend it of course.
> At the moment, my code isn't nice, but it works and should not break
> anything else. Would it be wise to commit that to the SVN now?
A plugin would have the advantage that everybody can try it out and drop
it again if they don't like it, without changes to their JOSM
installation. If I understand you correctly, people would have to apply
your patch and then recompile JOSM which few would do.
Ideally (I think) you should aim at making the required architecture
changes in the JOSM core without adding functionality (or bugs ;-)
there, and then make a Plugin that people can use if they want audio
mapping. But that's just my 2 cents.
More information about the josm-dev