<div dir="ltr">But that change actually breaks the intended change - binary exchange protocol.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">вс, 18 окт. 2020 г. в 08:37, Michael Bell <<a href="mailto:moke.byll@gmail.com">moke.byll@gmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I've had a go at reverting the breaking change:<br>
<a href="https://github.com/Project-OSRM/osrm-backend/pull/5860" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5860</a><br>
I was able to compile libosrmc against it.<br>
<br>
Michael<br>
<br>
On Thu, 15 Oct 2020 at 17:14, Denis Chapligin <<a href="mailto:akashihi@gmail.com" target="_blank">akashihi@gmail.com</a>> wrote:<br>
><br>
> IIRC you had some idea of hiding that change and unbreaking the API by templating ResultT type. If you can explain your idea I can probably implement it.<br>
><br>
> чт, 15 окт. 2020 г. в 17:43, Daniel Patterson via OSRM-talk <<a href="mailto:osrm-talk@openstreetmap.org" target="_blank">osrm-talk@openstreetmap.org</a>>:<br>
>><br>
>> Dammit, sorry Julien, I'd forgotten about that issue - I'm not using the libosrm bindings directly, so this change slipped my mind.<br>
>><br>
>> If someone has time to fix the interface, we can release 5.24.0 to address it, and mark 5.23.0 as a dud. The interface change clearly breaks semver rules as it's not backward compatible. The alternative would be to release OSRM 6.0.0, but this feels like much too small a change to justify doing that.<br>
>><br>
>> While I managed to find time to work through the release process, I do not have time to do any significant refactoring work :-/<br>
>><br>
>> daniel<br>
>><br>
>> On Thu, Oct 15, 2020 at 12:38 AM Julien Coupey <<a href="mailto:osm@coupey.fr" target="_blank">osm@coupey.fr</a>> wrote:<br>
>>><br>
>>> Hi Daniel and all<br>
>>><br>
>>> Thanks for your work on this release, and all the various recent<br>
>>> contributions that made it possible. It's great to see a new OSRM<br>
>>> version, first one in a long time!<br>
>>><br>
>>> I'd like to ask for a clarification though, if possible, on the status<br>
>>> of libosrm regarding this new version and possible future ones. There<br>
>>> are a couple of reports about the API breaking changes ([1] and [2]). It<br>
>>> means that projects relying on libosrm v5.* no longer compile with<br>
>>> v5.22, and now v5.23. This is a major problem for downstream users and<br>
>>> maintainers, especially since the OSRM release process has long been<br>
>>> adhering to the semver scheme. I only see two ways out:<br>
>>><br>
>>> 1. The new v5.23 release somehow endorses the API change (after all a<br>
>>> fix now would also be a new change from the last two releases). In which<br>
>>> case downstream users will have to fiddle with adjustments based on<br>
>>> libosrm minor version.<br>
>>><br>
>>> 2. This is considered as something that must be fixed at some point in<br>
>>> the future. Then no action is required downstream, except stating that<br>
>>> current libosrm versions are no longer compatible until a patch or new<br>
>>> minor version is released.<br>
>>><br>
>>> Knowing which option is the most likely would definitely help.<br>
>>><br>
>>> [1] <a href="https://github.com/Project-OSRM/osrm-backend/issues/5548" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/issues/5548</a><br>
>>> [2] <a href="https://github.com/Project-OSRM/osrm-backend/issues/5741" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/issues/5741</a><br>
>>><br>
>>> Regards<br>
>>> Julien<br>
>>><br>
>>> On 14/10/2020 23:14, Daniel Patterson via OSRM-talk wrote:<br>
>>> > Hello all,<br>
>>> ><br>
>>> > Well, after a long hiatus, I've finally had time to cut a new<br>
>>> > release. I've bundled up a bunch of the changes that have been<br>
>>> > submitted over the last couple of years, and tagged 5.23.0, and cleaned<br>
>>> > up the changelog/master branch which had been left dangling in an<br>
>>> > unclear state for a while. Build/publish of the various binaries is<br>
>>> > underway and should be complete soon. Here's what's changed - mostly<br>
>>> > bugfixes, but a few small features as well.<br>
>>> ><br>
>>> > - Changes from 5.22.0<br>
>>> > - Build:<br>
>>> > - FIXED: pessimistic calls to std::move<br>
>>> > [#5560](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5561" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5561</a>)<br>
>>> > - Features:<br>
>>> > - ADDED: new API parameter - `snapping=any|default` to allow<br>
>>> > snapping to previously unsnappable edges<br>
>>> > [#5361](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5361" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5361</a>)<br>
>>> > - ADDED: keepalive support to the osrm-routed HTTP server<br>
>>> > [#5518](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5518" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5518</a>)<br>
>>> > - ADDED: flatbuffers output format support<br>
>>> > [#5513](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5513" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5513</a>)<br>
>>> > - ADDED: Global 'skip_waypoints' option<br>
>>> > [#5556](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5556" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5556</a>)<br>
>>> > - FIXED: Install the libosrm_guidance library correctly<br>
>>> > [#5604](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5604" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5604</a>)<br>
>>> > - FIXED: Http Handler can now deal witch optional whitespace<br>
>>> > between header-key and -value<br>
>>> > [#5606](<a href="https://github.com/Project-OSRM/osrm-backend/issues/5606" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/issues/5606</a>)<br>
>>> > - Routing:<br>
>>> > - CHANGED: allow routing past `barrier=arch`<br>
>>> > [#5352](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5352" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5352</a>)<br>
>>> > - CHANGED: default car weight was reduced to 2000 kg.<br>
>>> > [#5371](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5371" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5371</a>)<br>
>>> > - CHANGED: default car height was reduced to 2 meters.<br>
>>> > [#5389](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5389" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5389</a>)<br>
>>> > - FIXED: treat `bicycle=use_sidepath` as no access on the tagged<br>
>>> > way. [#5622](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5622" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5622</a>)<br>
>>> > - FIXED: fix table result when source and destination on same<br>
>>> > one-way segment.<br>
>>> > [#5828](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5828" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5828</a>)<br>
>>> > - FIXED: fix occasional segfault when swapping data with<br>
>>> > osrm-datastore and using `exclude=`<br>
>>> > [#5844](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5844" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5844</a>)<br>
>>> > - FIXED: fix crash in MLD alternative search if source or target<br>
>>> > are invalid [#5851](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5851" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5851</a>)<br>
>>> > - Misc:<br>
>>> > - CHANGED: Reduce memory usage for raster source handling.<br>
>>> > [#5572](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5572" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5572</a>)<br>
>>> > - CHANGED: Add cmake option `ENABLE_DEBUG_LOGGING` to control<br>
>>> > whether output debug logging.<br>
>>> > [#3427](<a href="https://github.com/Project-OSRM/osrm-backend/issues/3427" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/issues/3427</a>)<br>
>>> > - CHANGED: updated extent of Hong Kong as left hand drive<br>
>>> > country. [#5535](<a href="https://github.com/Project-OSRM/osrm-backend/issues/5535" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/issues/5535</a>)<br>
>>> > - FIXED: corrected error message when failing to snap input<br>
>>> > coordinates [#5846](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5846" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5846</a>)<br>
>>> > - Infrastructure<br>
>>> > - REMOVED: STXXL support removed as STXXL became abandonware.<br>
>>> > [#5760](<a href="https://github.com/Project-OSRM/osrm-backend/pull/5760" rel="noreferrer" target="_blank">https://github.com/Project-OSRM/osrm-backend/pull/5760</a>)<br>
>>> ><br>
>>> > daniel<br>
>>> ><br>
>>> > _______________________________________________<br>
>>> > OSRM-talk mailing list<br>
>>> > <a href="mailto:OSRM-talk@openstreetmap.org" target="_blank">OSRM-talk@openstreetmap.org</a><br>
>>> > <a href="https://lists.openstreetmap.org/listinfo/osrm-talk" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/osrm-talk</a><br>
>>> ><br>
>>><br>
>>> _______________________________________________<br>
>>> OSRM-talk mailing list<br>
>>> <a href="mailto:OSRM-talk@openstreetmap.org" target="_blank">OSRM-talk@openstreetmap.org</a><br>
>>> <a href="https://lists.openstreetmap.org/listinfo/osrm-talk" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/osrm-talk</a><br>
>><br>
>> _______________________________________________<br>
>> OSRM-talk mailing list<br>
>> <a href="mailto:OSRM-talk@openstreetmap.org" target="_blank">OSRM-talk@openstreetmap.org</a><br>
>> <a href="https://lists.openstreetmap.org/listinfo/osrm-talk" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/osrm-talk</a><br>
><br>
> _______________________________________________<br>
> OSRM-talk mailing list<br>
> <a href="mailto:OSRM-talk@openstreetmap.org" target="_blank">OSRM-talk@openstreetmap.org</a><br>
> <a href="https://lists.openstreetmap.org/listinfo/osrm-talk" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/osrm-talk</a><br>
<br>
_______________________________________________<br>
OSRM-talk mailing list<br>
<a href="mailto:OSRM-talk@openstreetmap.org" target="_blank">OSRM-talk@openstreetmap.org</a><br>
<a href="https://lists.openstreetmap.org/listinfo/osrm-talk" rel="noreferrer" target="_blank">https://lists.openstreetmap.org/listinfo/osrm-talk</a><br>
</blockquote></div>