[Potlatch-dev] How about another build?
gravitystorm at gmail.com
Wed Dec 22 14:58:46 GMT 2010
On Wed, Dec 22, 2010 at 11:05 AM, Richard Fairhurst
<richard at systemed.net> wrote:
> Steve Bennett wrote:
>> Could we please have the live PL2 rebuilt? I fixed a pretty annoying
>> bug which prevented some imagery tiles ever being displayed.
> I think I'd like to review recent commits before the next deployment, if
> that's ok. With it being Christmas time is a bit short but I'll take a look
> when I can.
It's great to see so many bugfixes coming in. But Steve, can you avoid
hiding bug fixes in amongst other things, please? You're even
referring to the issue in your commit messages, c.f.
"In amongst all that there are two lines of code that fix the bug: "
"Fixed a bug [...] also, a bunch of random doco"
It's really hard to figure out what changes are being made - and to
review them, too - when they keep getting buried like this. Just do
more of what you're doing, but split into multiple commits so the
bugfixes are nice and easy to see!
P.S. For people used to git, I can totally recommend git-svn for
working with potlatch2, much easier to stage files for committing,
"git add -i" etc.
More information about the Potlatch-dev