[openstreetmap-website] New map UI (#328)

John Firebaugh notifications at github.com
Tue Jul 9 00:11:07 UTC 2013


This isn't quite ready to go (waiting on an upstream [Leaflet bug](https://github.com/Leaflet/Leaflet/pull/1846)), but I wanted to share and possibly get deployed for testing.

![image](https://f.cloud.github.com/assets/98601/765441/ff7a939a-e82b-11e2-8821-8874aa6c99ba.png)

Notable features:

* New layer chooser UI
* New geolocation control
* New share control (with room for "Include marker" checkbox and reorganization/consolidation with some of the "Export" features)
* Consistent style with map UI on other pages (just the zoom buttons)

Based on [work](https://github.com/samanpwbb/osm-redesign/blob/gh-pages/renders/layer-switcher.png) by @samanpwbb.
You can merge this Pull Request by running:

  git pull https://github.com/osmlab/openstreetmap-website map-ui

Or you can view, comment on it, or merge it online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/328

-- Commit Summary --

  * Remove pan and zoom controls
  * Basic framework for map UI
  * Remove unused styles
  * Add back basic zoom control
  * Add leaflet-locate control, invisible currently.
  * Remove permalink/add note links
  * Add locate widget to map
  * adding icons to sprite.
  * Start layers pane
  * Add share button to map
  * generate short link kind of
  * Prevent click propagation on ui panes
  * Remove unnecessary abstraction around rectangles
  * Start refactoring notes layer
  * Clean up some of the map JS, reduce scope of globals
  * Actually toggle note layer on click.
  * Refactor mapLayers to create layers up front
  * Add attrib
  * Restore attribution on main map
  * Start to refactor updatelinks
  * More refactoring of map js
  * Rename to L.OSM.Layers and continue implementation
  * Even more map ui js refactor
  * Use querystring, stop manually building urls
  * Refactor forever
  * Refactoring 4 life
  * starting to cleanup+style map controls.
  * Customize and style map zoom controls
  * Work on layers UI
  * Refactor layer persistence
  * Scope map variable.
  * Refactor out 'globals' from more functions
  * Layers work
  * Complete de-globalization of map
  * Layers work
  * Keep zoom buttons together
  * Arrange and group map buttons
  * Consistent JavaScript style
  * Port map key to new UI
  * Fix attribution width
  * Fix locate button style
  * Fix export
  * Only one pane visible at a time
  * Fix minimap event bindings
  * Implement long URL option, toggling, and labeling for share
  * Reuse styles for map-ui panel
  * Add layers code to share link
  * Focus share link by default
  * Add clearer close action, refactor base layer code
  * Add sprite and geolocate alternate color
  * Fix add note
  * Use custom zoom control everywhere
  * Include current non-OSM.org hostname in share URL
  * Move base layer UI above overlay layer UI
  * Fix export tab bugs
  * Use a radio button for base layers
  * Fix zoom out button style on non-main page maps

-- File Changes --

    M Vendorfile (12)
    M app/assets/images/sprite.png (0)
    M app/assets/images/sprite.svg (224)
    M app/assets/javascripts/application.js (264)
    M app/assets/javascripts/browse.js (70)
    M app/assets/javascripts/changeset.js (14)
    M app/assets/javascripts/diary_entry.js (15)
    M app/assets/javascripts/embed.js.erb (2)
    M app/assets/javascripts/index.js (242)
    M app/assets/javascripts/index/browse.js (36)
    M app/assets/javascripts/index/export.js (10)
    D app/assets/javascripts/index/key.js (34)
    M app/assets/javascripts/index/notes.js.erb (150)
    A app/assets/javascripts/leaflet.extend.js.erb (31)
    A app/assets/javascripts/leaflet.key.js (73)
    A app/assets/javascripts/leaflet.layers.js (165)
    A app/assets/javascripts/leaflet.note.js (19)
    A app/assets/javascripts/leaflet.share.js (85)
    A app/assets/javascripts/leaflet.sidebar.js (35)
    A app/assets/javascripts/leaflet.zoom.js (72)
    M app/assets/javascripts/map.js.erb (176)
    A app/assets/javascripts/querystring.js (71)
    M app/assets/javascripts/templates/notes/new.jst.ejs (2)
    M app/assets/javascripts/user.js (13)
    M app/assets/stylesheets/common.css.scss (145)
    M app/assets/stylesheets/large.css (6)
    M app/assets/stylesheets/leaflet-all.css.scss (17)
    D app/assets/stylesheets/leaflet.pan.css.scss (41)
    M app/assets/stylesheets/leaflet.zoom.css.scss (56)
    M app/views/layouts/site.html.erb (1)
    M app/views/site/_potlatch2.html.erb (4)
    M app/views/site/_search.html.erb (2)
    M app/views/site/id.html.erb (15)
    M app/views/site/index.html.erb (19)
    M config/locales/en.yml (21)
    A vendor/assets/leaflet/leaflet.locate.js (194)
    D vendor/assets/leaflet/leaflet.pan.js (52)
    D vendor/assets/leaflet/leaflet.zoom.js (213)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/328.patch
https://github.com/openstreetmap/openstreetmap-website/pull/328.diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20130708/ddc76d3b/attachment.html>


More information about the rails-dev mailing list