<p>Firstly, welcome, and thanks for contributing - enhancing our tests is always good!</p>
<p>Now this is a really big (in terms of lines changes) patch and it does a number of different things so I would really like it broken down into multiple commits.</p>
<p>Probably most of the bullet points in your pull request should be separate commits really.</p>
<p>We also need to think about whether we want to be doing wholesale reformatting of source code like this - it has the potential to cause major problems by provoking conflicts whether other people have outstanding work against the old code.</p>
<p>Finally, are we sure we really need to add all those encoding declarations? How many files (if any) do we have that have non-ASCII string constants? I know that I've been using 1.9.3 as my development environment for some months now without ever running into a problem.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">
—<br>
Reply to this email directly or <a href='https://github.com/openstreetmap/openstreetmap-website/pull/135#issuecomment-9498792'>view it on GitHub</a>.
</p>
<img src='https://github.com/notifications/beacon/J6T91GIPIyhU-8ti4GCGP98_UZTRAhtyIjAjorWDZ_l7-2ctyw8Ms5J7RSV4ZY8Q.gif' height='1' width='1'>