<p>I've rebased, made <code>rubocop</code> happy and fixed the tests on <a href="https://github.com/zerebubuth/openstreetmap-website/tree/moderation-rebased-2">a branch</a>. I think the code still needs a <em>lot</em> of work before it's ready to PR. Certainly it doesn't seem to have nearly enough tests to cover the amount of new code.</p>

<p>I'm still not entirely sure what's going on in many parts of the code, so will need to dig deeper to understand what else needs to be done, and what extra cases need tests. Any help cleaning it up further, testing it, commenting on it would be very welcome.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1268#issuecomment-241499420">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfDCH8gkuxHKfpQ914vQKpanuTIwks5qieXLgaJpZM4Jj6LN">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbhhwAj-0Oz6Hm136Io2OlalBPp3ks5qieXLgaJpZM4Jj6LN.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1268#issuecomment-241499420"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zerebubuth in #1268: I've rebased, made `rubocop` happy and fixed the tests on [a branch](https://github.com/zerebubuth/openstreetmap-website/tree/moderation-rebased-2). I think the code still needs a _lot_ of work before it's ready to PR. Certainly it doesn't seem to have nearly enough tests to cover the amount of new code.\r\n\r\nI'm still not entirely sure what's going on in many parts of the code, so will need to dig deeper to understand what else needs to be done, and what extra cases need tests. Any help cleaning it up further, testing it, commenting on it would be very welcome."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1268#issuecomment-241499420"}}}</script>