<p>Rubocop doesn't cover the xml builder files (*<em>/</em>.builder) automatically, so there were quite a few niggles with them.</p>
<p>Most were autofixes. The most important two to review are the consider_pd and terms_agreed changes, which have separate commits.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1277'>https://github.com/openstreetmap/openstreetmap-website/pull/1277</a></p>
<h4>Commit Summary</h4>
<ul>
<li>User.consider_pd is boolean, so no need for double negation.</li>
<li>Use .present? instead of double negative to check if terms_agreed timestamp is set.</li>
<li>Add outer variable shadowing to rubocop_todo.yml</li>
<li>Rubocop autofixes.</li>
<li>Add xml builder files to rubocop.</li>
<li>Update offense counts in rubocop_todo.yml</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-0">.rubocop.yml</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-1">.rubocop_todo.yml</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-2">app/views/api/permissions.builder</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-3">app/views/changeset/_comments.rss.builder</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-4">app/views/changeset/comments_feed.rss.builder</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-5">app/views/changeset/list.atom.builder</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-6">app/views/changeset/timeout.atom.builder</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-7">app/views/diary_entry/rss.rss.builder</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-8">app/views/notes/_note.gpx.builder</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-9">app/views/notes/_note.rss.builder</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-10">app/views/notes/_note.xml.builder</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-11">app/views/notes/feed.rss.builder</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-12">app/views/notes/index.gpx.builder</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-13">app/views/notes/index.rss.builder</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-14">app/views/notes/show.gpx.builder</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-15">app/views/notes/show.rss.builder</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-16">app/views/trace/georss.rss.builder</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277/files#diff-17">app/views/user/api_read.builder</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1277.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1277.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1277.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1277.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1277">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeawmMOjwfj1Nt1c3QPO6OR8TZVeks5qnpA5gaJpZM4J2w44">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLfIO0Z-0vtzh374WUrd_zFGqIgGMks5qnpA5gaJpZM4J2w44.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1277"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add rubocop coverage to xml builders (#1277)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1277"}}}</script>