<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1279#discussion_r77896748">test/models/diary_entry_test.rb</a>:</p>
<pre style='color:#555'>>    end
>  
>    private
>  
>    def diary_entry_valid(attrs, result = true)
> -    entry = DiaryEntry.new(diary_entries(:normal_user_entry_1).attributes)
> +    entry = DiaryEntry.new(attributes_for(:diary_entry))
</pre>
<p>Indeed can we not merge it with the next line as:</p>

<pre><code>entry = build(:diary_entry, attrs)
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1279/files/d5013ad0d2640693af534db47f891ca4fbbf5a4c..3b3f328ae4427ba0d1e3700ceabf7d0870f78dbd#r77896748">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLSo19w5t_3lqzkomX_0QWtWELqMYks5qnx3DgaJpZM4J3Dqy">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLZiGSas75_OXl5nW_04i13NB6a_bks5qnx3DgaJpZM4J3Dqy.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1279/files/d5013ad0d2640693af534db47f891ca4fbbf5a4c..3b3f328ae4427ba0d1e3700ceabf7d0870f78dbd#r77896748"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #1279: Indeed can we not merge it with the next line as:\r\n\r\n```\r\nentry = build(:diary_entry, attrs)\r\n```"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1279/files/d5013ad0d2640693af534db47f891ca4fbbf5a4c..3b3f328ae4427ba0d1e3700ceabf7d0870f78dbd#r77896748"}}}</script>