<p>This PR refactors that diary entry and diary comment tests to remove the associated fixtures. </p>

<p>Note that you may need to remove the fixtures from your test database, since there's nothing in the rails code that removes unnecessary fixtures after their definitions are deleted. Either reload the test database completely, or run "delete from" via psql for diary_entries and diary_comments.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1285'>https://github.com/openstreetmap/openstreetmap-website/pull/1285</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Test DiaryComment body validation</li>
  <li>Change the display_name of suspended user fixuture</li>
  <li>Refactor tests to use factories instead of fixtures</li>
  <li>Remove diary_entry and diary_comment fixtures, and refactor tests.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files#diff-0">test/controllers/diary_entry_controller_test.rb</a>
    (117)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files#diff-1">test/fixtures/diary_comments.yml</a>
    (35)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files#diff-2">test/fixtures/diary_entries.yml</a>
    (71)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files#diff-3">test/fixtures/users.yml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files#diff-4">test/models/diary_comment_test.rb</a>
    (7)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1285.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1285.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1285.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1285.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLV8xzKSYQaGfMrb0x27YIHkdnJQgks5qp_NwgaJpZM4J8wjJ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLX0cB27q9koFgjC_6nsZKohNWr8Bks5qp_NwgaJpZM4J8wjJ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1285"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Refactor diary tests (#1285)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1285"}}}</script>