<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285#discussion_r78803387">test/controllers/diary_entry_controller_test.rb</a>:</p>
<pre style='color:#555'>> end
>
> def test_list_user
> + diary_entry = create(:diary_entry)
> + geo_entry = create(:diary_entry, :latitude => 51.50763, :longitude => -0.10781)
</pre>
<p>So the problem here is that by only creating those two entries we are no longer testing that the right posts get selected because there are no non-matching posts in the database. Much the same applies to the other list tests.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files/d26f4074faf4fcc5ebb1b6a0928edf3aae9c2aee#r78803387">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLWHjSyOBFJxZs_RDbv3z2aoiUh5_ks5qqDgOgaJpZM4J8wjJ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLSgwOdqdjOfqUpaKZgGGCL3knP3mks5qqDgOgaJpZM4J8wjJ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1285/files/d26f4074faf4fcc5ebb1b6a0928edf3aae9c2aee#r78803387"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #1285: So the problem here is that by only creating those two entries we are no longer testing that the right posts get selected because there are no non-matching posts in the database. Much the same applies to the other list tests."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1285/files/d26f4074faf4fcc5ebb1b6a0928edf3aae9c2aee#r78803387"}}}</script>