<p>OK so I think I've addressed the comments.</p>

<ul>
<li>Changed the installed packages to follow the minimum requirements specified in <code>INSTALL.md</code>
</li>
<li>Use <code>bundle exec rails s -p 3000 -b '0.0.0.0'</code>
</li>
<li>Moved <code>docker_postgres.sh</code> into <code>/db</code> to reduce the noise in the root directory (I can't move all the files due to the way docker will not <code>../</code> backwards to access files)</li>
<li>Added more info to the <code>DOCKER.md</code>
</li>
<li>Tweaked the <code>INSTALL.md</code> to state installing directly is best supported approach.</li>
</ul>

<p>The app boots and it appears to load ok, but I'm not familiar with it at all.</p>

<p>There are 4 specs that either error or fail locally. The output is below. Does anyone know what might be causing those? </p>

<p></p><details><br>
<summary>Spec failure output</summary><p></p>

<pre><code>1) Error:
DiaryEntryTest#test_diary_entry_visible_comments:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:37:in `test_diary_entry_visible_comments'


  2) Error:
DiaryEntryTest#test_diary_entry_comments:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:30:in `test_diary_entry_comments'


  3) Error:
DiaryEntryTest#test_diary_entry_visible:
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table "diary_entries" violates foreign key constraint "diary_entries_language_code_fkey"
DETAIL:  Key (language_code)=(en) is not present in table "languages".
: INSERT INTO "diary_entries" ("title", "body", "user_id", "created_at", "updated_at") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
    test/models/diary_entry_test.rb:21:in `test_diary_entry_visible'


  4) Failure:
TraceTest#test_xml_file [/app/test/models/trace_test.rb:145]:
--- expected
+++ actual
@@ -1 +1,2 @@
-"848caa72f2f456d1bd6a0fdf228aa1b9"
+# encoding: US-ASCII
+"d41d8cd98f00b204e9800998ecf8427e"
</code></pre>

<p></p></details><p></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#issuecomment-247765213">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTJTkDzU8W4StZ1BLfx-AkF9EiZQks5qq9QBgaJpZM4J-dnj">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbIEEGuulH-oVF3kKkUsZivcaJ2jks5qq9QBgaJpZM4J-dnj.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#issuecomment-247765213"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@paulsturgess in #1290: OK so I think I've addressed the comments.\r\n\r\n- Changed the installed packages to follow the minimum requirements specified in `INSTALL.md`\r\n- Use `bundle exec rails s -p 3000 -b '0.0.0.0'`\r\n- Moved `docker_postgres.sh` into `/db` to reduce the noise in the root directory (I can't move all the files due to the way docker will not `../` backwards to access files)\r\n- Added more info to the `DOCKER.md`\r\n- Tweaked the `INSTALL.md` to state installing directly is best supported approach.\r\n\r\nThe app boots and it appears to load ok, but I'm not familiar with it at all.\r\n\r\nThere are 4 specs that either error or fail locally. The output is below. Does anyone know what might be causing those? \r\n\r\n\u003cdetails\u003e\r\n\u003csummary\u003eSpec failure output\u003c/summary\u003e\r\n```\r\n1) Error:\r\nDiaryEntryTest#test_diary_entry_visible_comments:\r\nActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table \"diary_entries\" violates foreign key constraint \"diary_entries_language_code_fkey\"\r\nDETAIL:  Key (language_code)=(en) is not present in table \"languages\".\r\n: INSERT INTO \"diary_entries\" (\"title\", \"body\", \"user_id\", \"created_at\", \"updated_at\") VALUES ($1, $2, $3, $4, $5) RETURNING \"id\"\r\n    test/models/diary_entry_test.rb:37:in `test_diary_entry_visible_comments'\r\n\r\n\r\n  2) Error:\r\nDiaryEntryTest#test_diary_entry_comments:\r\nActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table \"diary_entries\" violates foreign key constraint \"diary_entries_language_code_fkey\"\r\nDETAIL:  Key (language_code)=(en) is not present in table \"languages\".\r\n: INSERT INTO \"diary_entries\" (\"title\", \"body\", \"user_id\", \"created_at\", \"updated_at\") VALUES ($1, $2, $3, $4, $5) RETURNING \"id\"\r\n    test/models/diary_entry_test.rb:30:in `test_diary_entry_comments'\r\n\r\n\r\n  3) Error:\r\nDiaryEntryTest#test_diary_entry_visible:\r\nActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  insert or update on table \"diary_entries\" violates foreign key constraint \"diary_entries_language_code_fkey\"\r\nDETAIL:  Key (language_code)=(en) is not present in table \"languages\".\r\n: INSERT INTO \"diary_entries\" (\"title\", \"body\", \"user_id\", \"created_at\", \"updated_at\") VALUES ($1, $2, $3, $4, $5) RETURNING \"id\"\r\n    test/models/diary_entry_test.rb:21:in `test_diary_entry_visible'\r\n\r\n\r\n  4) Failure:\r\nTraceTest#test_xml_file [/app/test/models/trace_test.rb:145]:\r\n--- expected\r\n+++ actual\r\n@@ -1 +1,2 @@\r\n-\"848caa72f2f456d1bd6a0fdf228aa1b9\"\r\n+# encoding: US-ASCII\r\n+\"d41d8cd98f00b204e9800998ecf8427e\"\r\n```\r\n\u003c/details\u003e"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1290#issuecomment-247765213"}}}</script>