<p><b>@gravitystorm</b> commented on this pull request.</p>

<p>Code looks good, a couple of notes on the comments</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1309#pullrequestreview-3293538">test/controllers/diary_entry_controller_test.rb</a>:</p>
<pre style='color:#555'>> +  ##
+  # test unsubscribe fail
+  def test_unsubscribe_fail
+    diary_entry = create(:diary_entry, :user_id => users(:normal_user).id)
+
+    # not signed in
+    assert_no_difference "diary_entry.subscribers.count" do
+      post :unsubscribe, :id => diary_entry.id, :display_name => diary_entry.user.display_name
+    end
+    assert_response :forbidden
+
+    # bad diary id
+    post :unsubscribe, { :id => 999111, :display_name => "username" }, { :user => users(:public_user).id }
+    assert_response :not_found
+
+    # trying to subscribe when already subscribed
</pre>
<p>This comment should be "trying to unsubscribe when not subscribed"</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1309#pullrequestreview-3293538">test/controllers/diary_entry_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -641,6 +662,72 @@ def test_comments
     assert_response :not_found
   end
 
+  ##
+  # test subscribe success
+  def test_subscribe_success
</pre>
<p>I'm not sure the comments here are adding anything - they are just repeating the name of the test without the underscores. (+further 3 times below)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1309#pullrequestreview-3293538">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLcFKW10lVXbVy8Hou0d_6efZue01ks5qxj6lgaJpZM4KNPYt">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbmZitJEKW5W9gWTcmfrTDbxEbldks5qxj6lgaJpZM4KNPYt.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1309#pullrequestreview-3293538"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm commented on #1309"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1309#pullrequestreview-3293538"}}}</script>