<p>The mocking and stubbing in the controller tests is<br>
unfortunate, but the models interact directly with the filesystem<br>
using the trace id so that's hard to control any other way.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1347'>https://github.com/openstreetmap/openstreetmap-website/pull/1347</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Replace trace-related fixtures with factories.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-0">test/controllers/amf_controller_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-1">test/controllers/api_controller_test.rb</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-2">test/controllers/site_controller_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-3">test/controllers/swf_controller_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-4">test/controllers/trace_controller_test.rb</a>
    (683)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-5">test/controllers/user_controller_test.rb</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-6">test/factories/tracepoints.rb</a>
    (11)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-7">test/factories/traces.rb</a>
    (16)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-8">test/factories/tracetags.rb</a>
    (7)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-9">test/fixtures/gps_points.yml</a>
    (35)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-10">test/fixtures/gpx_file_tags.yml</a>
    (19)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-11">test/fixtures/gpx_files.yml</a>
    (129)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-12">test/integration/oauth_test.rb</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-13">test/models/trace_test.rb</a>
    (178)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-14">test/models/tracepoint_test.rb</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-15">test/models/tracetag_test.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347/files#diff-16">test/test_helper.rb</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1347.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1347.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1347.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1347.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1347">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLUQkz2EhcC8gviItl1AosI5o_XFcks5q41cMgaJpZM4KkH9o">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLe6onVzZ9uBn7LoVjSLGAs3lPkaJks5q41cMgaJpZM4KkH9o.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1347"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Replace trace-related fixtures with factories. (#1347)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1347"}}}</script>