<p>I found while offline that many of the tests make real http requests. Using <a href="https://github.com/bblimke/webmock">webmock</a> means these are disabled by default, and need to be explicitly stubbed - this ensures that http requests aren't accidentally overlooked when they are written while online.</p>

<p>Later I found that some http requests were being mocked out using the stub_http_requests method, so I've refactored that to use webmock too. I also refactored some gravatar tests to improve their clarity, and removed their http fixture since it was just dummy responses anyway.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1350'>https://github.com/openstreetmap/openstreetmap-website/pull/1350</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add webmock to intercept real http connections during tests</li>
  <li>Stub out requests to hostip.info during tests</li>
  <li>Stub out requests to gravatar.com during tests.</li>
  <li>Use webmock to power the with_http_stubs helper</li>
  <li>Refactor the gravatar email changes to use webmock stubbing</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-0">Gemfile</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-1">Gemfile.lock</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-2">lib/osm.rb</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-3">test/controllers/site_controller_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-4">test/controllers/user_controller_test.rb</a>
    (61)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-5">test/http/geocoder_ca.yml</a>
    (14)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-6">test/http/gravatar.yml</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-7">test/http/nominatim.yml</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-8">test/http/npemap.yml</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-9">test/integration/oauth_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-10">test/integration/page_locale_test.rb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-11">test/integration/user_creation_test.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-12">test/integration/user_roles_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-13">test/integration/user_terms_seen_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350/files#diff-14">test/test_helper.rb</a>
    (26)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1350.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1350.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1350.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1350.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1350">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLXcCKdZfg2tdkrN1Aracg7b0ombaks5q5HDGgaJpZM4KkVyV">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbzqpJCkoFsse4CsJ4IncpUjuEofks5q5HDGgaJpZM4KkVyV.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1350"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Use Webmock to intercept http requests in tests (#1350)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1350"}}}</script>