<p><b>@mojodna</b> commented on this pull request.</p>

<p>(Sorry, didn't mean to trigger a review on this.)</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675">Dockerfile</a>:</p>
<pre style='color:#555'>> +  libpq-dev \
+  libxml2-dev \
+  imagemagick \
+  libmagickwand-dev \
+  postgresql-client \
+  nodejs \
+  file
+
+# Setup app location
+RUN mkdir -p /app
+WORKDIR /app
+
+# Install gems
+ADD Gemfile /app/Gemfile
+ADD Gemfile.lock /app/Gemfile.lock
+RUN bundle install
</pre>
<p>(Commenting here because it's the end of the file.)</p>

<p><code>COPY . /app</code> should be included if this image is intended to be used independently of a local git clone, otherwise none of the source files will be available in the image.</p>

<p>(This can co-exist happily with mapping <code>$(pwd)</code> to <code>/app</code> as a volume; files present in the image will be shadowed by local paths.)</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675">Dockerfile</a>:</p>
<pre style='color:#555'>> +  libpq-dev \
+  libxml2-dev \
+  imagemagick \
+  libmagickwand-dev \
+  postgresql-client \
+  nodejs \
+  file
+
+# Setup app location
+RUN mkdir -p /app
+WORKDIR /app
+
+# Install gems
+ADD Gemfile /app/Gemfile
+ADD Gemfile.lock /app/Gemfile.lock
+RUN bundle install
</pre>
<p>Also consider adding <code>-j $(nproc)</code> as an argument to speed up gem installation (it will run a number of processes matching the cores available on the system doing the building).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLc1yASK2ak-hA3ey8ePkMt1BTG99ks5q5lzygaJpZM4J-dnj">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLVhyfqyALp7P1N4R99b74E20iPplks5q5lzygaJpZM4J-dnj.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mojodna commented on #1290"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1290#pullrequestreview-6528675"}}}</script>