<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1367">test/controllers/relation_controller_test.rb</a>:</p>
<pre style='color:#555'>> @@ -337,6 +337,7 @@ def test_create
   def test_update_relation_tags
     basic_authorization "test@example.com", "test"
     rel_id = current_relations(:multi_tag_relation).id
+    create_list(:relation_tag, 4, :relation => current_relations(:multi_tag_relation))
</pre>
<p>I don't know what the original bug was that's hinted at in the comment. Since the test involves updating an existing tag I though it best to include more than one (the fixtures had four tags, so I stuck with that). As you say, it doesn't seem to matter that the db is in an initially inconsistent state, since after the update, it's the new version that is checked, not the old version that has no tags.</p>

<p>I can propagate the tags if you think it's worthwhile though.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1367">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLY_7anT-ChfmrYTUWUSQOjBRaYt8ks5q_DZwgaJpZM4KtvV_">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLXQAomb95s1CjbDW44FNc7GgwyH8ks5q_DZwgaJpZM4KtvV_.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1367"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm commented on #1367"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1367"}}}</script>