<p>In RSS and Atom feeds, we need to supply the full url (i.e. with hostname) when constructing links to images. We use <code>image_path("foo.png", :host => SERVER_URL)</code> and <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1378" class="issue-link js-issue-link" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1378" data-id="191573128" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1378</a> makes this consistent.</p>
<p>However, there's an alternative: <code>image_url("foo.png")</code>, which also generates full urls. It seems to work to me. All of our <code>url_for(foo, :only_path => false)</code> work for generating urls for non-image paths, without needing SERVER_URL to be passed around.</p>
<p>Is there any reason that I haven't figured out to stick with <code>image_path</code> instead of <code>image_url</code>?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1379">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeqlyLdNFi8UxRxOfTcPGWqlSfy5ks5rBdvNgaJpZM4K752N">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLeyF_FZVIlAKlEvAJebaN3qoScz0ks5rBdvNgaJpZM4K752N.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/issues/1379"></link>
<meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Use image_url instead of image_path in feeds? (#1379)"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1379"}}}</script>