<p><a href="https://github.com/pnorman" class="user-mention">@pnorman</a> thanks for the valuable feedback!</p>
<blockquote>
<p>Shouldn't thin use image_path or something? Explicitly building a path to an asset like that seems wrong.</p>
</blockquote>
<p>I'll look into <code>image_path</code>.</p>
<blockquote>
<p>can't we add it as part of the commenter expansion and achieve the same result?</p>
</blockquote>
<p>Yes, that sounds like it would make sense. As I wrote above, I too am not comfortable with having HTML/CSS in the locale files. I'll move the HTML bits to Rubyland, which feels.. less wrong?</p>
<p>I'd rather keep the <code><strong></code> emphasis on the user name, though, I think it makes sense for that information to stand out. Unless others disagree?</p>
<blockquote>
<p>Is there something clever we can do here with a layout?</p>
</blockquote>
<p>Aha, I think "layouts" might be the Rails keyword I was missing for the template-template I was trying to describe above -- I'll look that up.</p>
<p>I'll try to implement the above in the coming days.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#issuecomment-269951125">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLXAwNFlkHs2Eh4rfs3OeMKsmend2ks5rOMiAgaJpZM4LYyok">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLQIv_rCdcVKbyMzkFNKsq5C17wLIks5rOMiAgaJpZM4LYyok.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#issuecomment-269951125"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@saintamh in #1401: @pnorman thanks for the valuable feedback!\r\n\r\n\u003e Shouldn't thin use image_path or something? Explicitly building a path to an asset like that seems wrong.\r\n\r\nI'll look into `image_path`.\r\n\r\n\u003e can't we add it as part of the commenter expansion and achieve the same result?\r\n\r\nYes, that sounds like it would make sense. As I wrote above, I too am not comfortable with having HTML/CSS in the locale files. I'll move the HTML bits to Rubyland, which feels.. less wrong?\r\n\r\nI'd rather keep the `\u003cstrong\u003e` emphasis on the user name, though, I think it makes sense for that information to stand out. Unless others disagree?\r\n\r\n\u003e Is there something clever we can do here with a layout?\r\n\r\nAha, I think \"layouts\" might be the Rails keyword I was missing for the template-template I was trying to describe above -- I'll look that up.\r\n \r\nI'll try to implement the above in the coming days."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1401#issuecomment-269951125"}}}</script>