<p><b>@tomhughes</b> requested changes on this pull request.</p>

<p>A few more review comments. There's also a live version running at <a href="http://tomh.apis.dev.openstreetmap.org/">http://tomh.apis.dev.openstreetmap.org/</a> if people want to test things.</p><hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344">app/helpers/notifier_helper.rb</a>:</p>
<pre style='color:#555'>> +    link_to(
+      display_name,
+      user_url(display_name, :host => SERVER_URL),
+      :target => "_blank",
+      :style => "text-decoration: none; color: #222; font-weight: bold"
+    )
+  end
+
+  def message_body(&block)
+    render(
+      :partial => "message_body",
+      :locals => { :body => capture(&block) }
+    )
+  end
+
+  def apply_inline_css(html)
</pre>
<p>I think <code>apply_inline_css</code> is a bit too vague for the name - something like <code>style_message</code> would make it clearer what it does.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344">test/test_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -185,5 +185,17 @@ def stub_hostip_requests
       stub_request(:get, "http://api.hostip.info/country.php?ip=0.0.0.0")
       stub_request(:get, "http://api.hostip.info/country.php?ip=127.0.0.1")
     end
+
+    def email_text_parts(message)
+      text_parts = []
+      message.parts.each do |part|
</pre>
<p>You could avoid initialising the array and then returning it by using <code>each_with_object</code> here. So something like:</p>
<pre><code>message.parts.each_with_object([]) do |part,text_parts|
</code></pre>
<p>and then get rid of the first and last lines of the method.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344">app/views/notifier/changeset_comment_notification.html.erb</a>:</p>
<pre style='color:#555'>>  
-<p><%= raw t 'notifier.changeset_comment_notification.details', :url => link_to(@changeset_url, @changeset_url) %></p>
+<% content_for :footer do %>
+  <p>
+    <%= raw t 'notifier.changeset_comment_notification.unsubscribe', :url => link_to(@changeset_url, @changeset_url, :style => "color: #222; white-space: nowrap") %>
</pre>
<p>If you're going to add completely new information to the message then it should really be added to the text version as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLRnJ7iCNQ_oIwSV1cX4WnLPagCghks5rW3CngaJpZM4LYyok">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbEsatoDENUSo-UC-K-8POwg6AE2ks5rW3CngaJpZM4LYyok.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1401"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1401#pullrequestreview-18976344"}}}</script>