<p><b>@simonpoole</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101895976">app/models/user_block.rb</a>:</p>
<pre style='color:#555'>> @@ -27,6 +27,12 @@ def active?
end
##
+ # returns true if the block is a "zero hour" block
+ def zero_hour?
+ needs_view && (ends_at.to_i == updated_at.to_i)
</pre>
<p>If I understand things correctly we have roughly three cases that we care about</p>
<ol>
<li>needs_view set, duration of block ~0 -> "zero hour block"</li>
<li>needs_view set, duration of block >> 0 -> longish block were we still want to communicate to the user</li>
<li>needs_view not set -> no messaging to the user</li>
</ol>
<p>Currently all three cases get the same message. With this PR (1) gets a slightly friendlier message than (2) and (3), but we could further differentiate these if we wanted to ie remove the reference to having to log in.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101895976">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLVhCYFsLeHoOWOx_wVDwERswh5yEks5rdxaBgaJpZM4MFHfC">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLWCEUZDFmecLkJkjPyhwCgvbIx65ks5rdxaBgaJpZM4MFHfC.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101895976"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@simonpoole commented on #1443"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101895976"}}}</script>