<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101894495">app/models/user_block.rb</a>:</p>
<pre style='color:#555'>> @@ -27,6 +27,12 @@ def active?
end
##
+ # returns true if the block is a "zero hour" block
+ def zero_hour?
+ needs_view && (ends_at.to_i == updated_at.to_i)
</pre>
<p>Do the times really need to be converted to integers before comparing them?</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#discussion_r101894498">app/controllers/application_controller.rb</a>:</p>
<pre style='color:#555'>> set_locale
- report_error t("application.setup_user_auth.blocked"), :forbidden
+ if @user.blocks.active.take.zero_hour?
</pre>
<p>What was the point of creating <code>user_block</code> if you're then not going to use it ;-)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#pullrequestreview-22639236">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTABrxdLBLFP5QpVKfieY4RArtDcks5rdwYugaJpZM4MFHfC">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLe3HMfDPbgoSDFgXeyOqH0A9V6hxks5rdwYugaJpZM4MFHfC.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1443#pullrequestreview-22639236"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1443"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1443#pullrequestreview-22639236"}}}</script>