<blockquote>
<p>What would you do during diff upload to fix this?</p>
</blockquote>
<p>I assumed it would take one pass over the data to assign primary keys and then a second pass to actually insert the stuff into the database.  But I do understand it's easier to have it work the way it does in a single pass.</p>
<p>If you don't want to change how key assignment happens, thats ok with me - it just means I'll need to change iD to reorder the relations, and also add some checks to prevent users from creating circular relation graphs (we all agree they should be avoided).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1465#issuecomment-282414758">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLXq-FjhCuzlw-EGyzVf2jF5hLq0Lks5rf1BggaJpZM4MLUZv">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLTrGgM7rJ4YVhd8_VgOHvKSaaRdiks5rf1BggaJpZM4MLUZv.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/issues/1465#issuecomment-282414758"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bhousel in #1465: \u003e What would you do during diff upload to fix this?\r\n\r\nI assumed it would take one pass over the data to assign primary keys and then a second pass to actually insert the stuff into the database.  But I do understand it's easier to have it work the way it does in a single pass.\r\n\r\nIf you don't want to change how key assignment happens, thats ok with me - it just means I'll need to change iD to reorder the relations, and also add some checks to prevent users from creating circular relation graphs (we all agree they should be avoided)."}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1465#issuecomment-282414758"}}}</script>