<p>In PR <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1401" class="issue-link js-issue-link" data-url="https://github.com/openstreetmap/openstreetmap-website/issues/1401" data-id="198285390" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#1401</a> we added a new I18N string, <code>notifier.changeset_comment_notification.hi</code>, whose value is <code>"Hi %{to_user},"</code>. It's now been translated to 32 languages (if I'm grepping right).</p>
<p>The only other email that doesn't already open with a greeting is <code>friend_notification</code>.</p>
<p>This PR does two things:</p>
<ol>
<li>start using the new string in the changeset comment notification template</li>
<li>add a a new string, <code>notifier.friend_notification.hi</code>, which is a copy of the <code>changeset_comment_notification.hi</code> (IIUC there's no way around the translatewiki pipeline, even for strings that are identical to previous ones?) Once translated this can be added to the friend_notification templates.</li>
</ol>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1469'>https://github.com/openstreetmap/openstreetmap-website/pull/1469</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Included greeting string in changeset_comment_notification email</li>
  <li>Added new I18N string: notifier.friend_notification.hi</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1469/files#diff-0">app/models/notifier.rb</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1469/files#diff-1">app/views/notifier/changeset_comment_notification.html.erb</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1469/files#diff-2">app/views/notifier/changeset_comment_notification.text.erb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1469/files#diff-3">config/locales/en.yml</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1469.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1469.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1469.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1469.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1469">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeXb7RQ8UztaH2xoQ6X7TTFLt-fwks5rg1JdgaJpZM4MNuw1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLWpkDErTK4o7bgwXHQUYwIhRhVhdks5rg1JdgaJpZM4MNuw1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1469"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add greeting to changeset comment notification (#1469)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1469"}}}</script>