<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1478#discussion_r104799833">app/assets/javascripts/index.js</a>:</p>
<pre style='color:#555'>> +    },
+    Android: function() {
+        return /Android/i.test(navigator.userAgent);
+    },
+    BlackBerry: function() {
+        return /BlackBerry/i.test(navigator.userAgent);
+    },
+    iOS: function() {
+        return /iPhone|iPad|iPod/i.test(navigator.userAgent);
+    },
+    any: function() {
+        return (isMobile.Android() || isMobile.BlackBerry() || isMobile.iOS() || isMobile.Windows());
+    }
+  };
+
+  function url() {
</pre>
<p>This is far too vague as a name for this function at this scope - it should either be more explanatory or the function should be pushed down inside <code>remoteEditHandler</code> so that the meaning is implicit.</p>
<p>That said I'm not really sure we it needs to be a function and can't just be done inline in <code>remoteEditHandler</code> without having to repeat the android test...</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1478#discussion_r104800004">app/assets/javascripts/index.js</a>:</p>
<pre style='color:#555'>> @@ -255,17 +281,17 @@ $(document).ready(function () {
     var iframe = $('<iframe>')
         .hide()
         .appendTo('body')
-        .attr("src", url + querystring.stringify(query))
+        .attr("src", url() + querystring.stringify(query) + (android ? '#Intent;scheme=josm;end;':''))
</pre>
<p>If <code>url</code> is going to stay as a function then I would just pass <code>query</code> in to it and let it figure out the whole URL in one go rather than splitting the logic for the intent URL across two different locations.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1478#pullrequestreview-25652556">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLU5jNG-V66J4Yy8LepdGNvaYk4iQks5rjd1PgaJpZM4MVzZ7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLaT_xcbu2sMMHCRAWBTpsnpC9Z72ks5rjd1PgaJpZM4MVzZ7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1478#pullrequestreview-25652556"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1478"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1478#pullrequestreview-25652556"}}}</script>