<p>Well it's true that those whole tests are of dubious validity since the username used in the URL doesn't actually mean anything as you say.</p>
<p>That's a "white box testing" argument of course, where you as tester know what is really going on, while the "black box" argument would be that you don't know that and you're testing whether it behaves differently when logged in as the alleged user. Of course in that case you can then argue for a third test to check what happens when logged in as a different user ;-)</p>
<p>What is definitely true is that the test is not doing the same thing as before, and different tests with essentially the same logic have been converted in inconsistent ways.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#issuecomment-285362167">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLX23f05tfveVryDmP2uQvchaQ1wkks5rkAmUgaJpZM4MX_SV">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLZvvbPKnHsZnSSBBuCTEJ39B-Br8ks5rkAmUgaJpZM4MX_SV.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#issuecomment-285362167"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes in #1481: Well it's true that those whole tests are of dubious validity since the username used in the URL doesn't actually mean anything as you say.\r\n\r\nThat's a \"white box testing\" argument of course, where you as tester know what is really going on, while the \"black box\" argument would be that you don't know that and you're testing whether it behaves differently when logged in as the alleged user. Of course in that case you can then argue for a third test to check what happens when logged in as a different user ;-)\r\n\r\nWhat is definitely true is that the test is not doing the same thing as before, and different tests with essentially the same logic have been converted in inconsistent ways."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1481#issuecomment-285362167"}}}</script>