<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105162235">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :not_found
 
     # Now with some other user, which should work since the trace is public
-    get :picture, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user) }
+    get :picture, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user) }
</pre>
<p>That's not doing the same thing any more as it is now authenticating as a different user to the one that nominally owns the non-existent trace.</p>
<p>In the previous test that did the same thing you created the deleted trace up front and used that user throughout.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105162285">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :not_found
 
     # Now with some other user
-    get :icon, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user) }
+    get :icon, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user) }
</pre>
<p>Same issue here as above.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105162668">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :forbidden
 
     # Now with a trace which doesn't exist
-    get :edit, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user) }
+    get :edit, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user) }
</pre>
<p>Same again...</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105162788">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :forbidden
 
     # Now with a trace which doesn't exist
-    post :edit, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user) }
+    post :edit, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user) }
</pre>
<p>Guess what ;-)</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105163143">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :forbidden
 
     # Now with a trace which doesn't exist
-    post :edit, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user), :trace => new_details }
+    post :edit, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user), :trace => new_details }
</pre>
<p><g-emoji alias="recycle" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/267b.png" ios-version="6.0">♻️</g-emoji></p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105163375">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :forbidden
 
     # Now with a trace which doesn't exist
-    post :delete, { :display_name => users(:public_user).display_name, :id => 0 }, { :user => users(:public_user) }
+    post :delete, { :display_name => create(:user).display_name, :id => 0 }, { :user => create(:user) }
</pre>
<p><g-emoji alias="recycle" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/267b.png" ios-version="6.0">♻️</g-emoji></p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#discussion_r105163828">test/controllers/trace_controller_test.rb</a>:</p>
<pre style='color:#555'>>      assert_response :unauthorized
 
     # Now with a trace that has never existed
-    basic_authorization(users(:public_user).display_name, "test")
-    get :api_data, :display_name => users(:public_user).display_name, :id => 0
+    basic_authorization(create(:user).display_name, "test")
+    get :api_data, :display_name => create(:user).display_name, :id => 0
</pre>
<p><g-emoji alias="recycle" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/267b.png" ios-version="6.0">♻️</g-emoji></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#pullrequestreview-26027619">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTZPL8fJEj0hCdHhxal2oiU_59pbks5rkAIZgaJpZM4MX_SV">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLQ5_db61s3kH_I3Ndd5cXRwtakwKks5rkAIZgaJpZM4MX_SV.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1481#pullrequestreview-26027619"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1481"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1481#pullrequestreview-26027619"}}}</script>