<p><b>@tomhughes</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1488#discussion_r106152488">test/controllers/user_controller_test.rb</a>:</p>
<pre style='color:#555'>>      ActionMailer::Base.deliveries.clear
   end
 
   def test_reset_password
+    user = create(:user)
</pre>
<p>This needs a <code>:pending</code> as it was using the inactive user before and part of the test is checking that doing a password reset on a pending user activates the user as a side-effect.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1488#pullrequestreview-27060219">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLUln3GzJJMlC0Go4e5btTMCNS_Qfks5rl9vHgaJpZM4Md2Fl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLaoWMr94_UglOB5RzLLD-IJTIymEks5rl9vHgaJpZM4Md2Fl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1488#pullrequestreview-27060219"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1488"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1488#pullrequestreview-27060219"}}}</script>