<p><b>@gravitystorm</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492#discussion_r106257205">test/controllers/old_node_controller_test.rb</a>:</p>
<pre style='color:#555'>>  
     do_redact_node(nodes(:node_with_versions_v3),
-                   redactions(:example))
+                   create(:redaction, :user => user))
</pre>
<p>For the tests that succeed, there was previously a correlation in that the fixture redaction was owned by <code>users(:moderator_user)</code>, which was the same user as the one used for logging in. So I thought it best to make those ones owned by the same moderator, and therefore even the failing ones like this should be owned by the same user, just in case.</p>
<p>But you're right, of course, this isn't actually required. I didn't check the controller code.</p>
<p>There's also a design issue here that I had in the back of my mind. For redactions it is currently possible for moderators to use a redaction created by someone else, and even edit it. But for user blocks, only the moderator that created one can edit it. So the "ownership" behaviour of user_blocks is quite different from redactions. There might be advantages in aligning the behaviour one way or the other in future.</p>
<p>If you'd prefer that I remove these (currently?) unnecessary ownerships in the tests, I'm happy to do that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492#discussion_r106257205">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeTq5JVeuvCEGDVcfzwjC0HZcby0ks5rmDc3gaJpZM4MeU4R">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLag5mYolL6BTRpsBm9YV7wjLPddeks5rmDc3gaJpZM4MeU4R.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1492#discussion_r106257205"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm commented on #1492"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1492#discussion_r106257205"}}}</script>