<p>This replaces the fixtures in the user_controller tests with factories.</p>
<p>Note that two of the tests still have explicit dependencies on the fixtures, where they are counting the total number of users in the database. But we can't remove the fixtures yet since there's still more refactoring to do.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1488'>https://github.com/openstreetmap/openstreetmap-website/pull/1488</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Build pending users via factory</li>
  <li>Use users factory for user_controller tests.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1488/files#diff-0">test/controllers/user_controller_test.rb</a>
    (350)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1488.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1488.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1488.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1488.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1488">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbrfxyf6yQ70dxXlBH6vnxbOITKRks5rl9JxgaJpZM4Md2Fl">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLY0xDIzwBOEoeD3SM-RP8O_4WeAPks5rl9JxgaJpZM4Md2Fl.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1488"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"User factory for user_controller tests (#1488)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1488"}}}</script>