<p>This PR creates a redaction factory and uses it wherever the redactions fixtures were used explicitly. The redactions fixture is still used indirectly by various other fixtures so needs to wait for them to be refactored before it can be removed.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1492'>https://github.com/openstreetmap/openstreetmap-website/pull/1492</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Create a redactions factory and use for model tests.</li>
  <li>Use redactions factory in redaction controller test.</li>
  <li>Fix typos in assertion messages.</li>
  <li>Use redaction factory for old_relation controller tests.</li>
  <li>Use redactions factory for old_node controller tests.</li>
  <li>Use redactions factory for old_way controller tests</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-0">test/controllers/old_node_controller_test.rb</a>
    (36)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-1">test/controllers/old_relation_controller_test.rb</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-2">test/controllers/old_way_controller_test.rb</a>
    (33)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-3">test/controllers/redactions_controller_test.rb</a>
    (30)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-4">test/factories/old_node.rb</a>
    (16)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-5">test/factories/redaction.rb</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492/files#diff-6">test/models/redaction_test.rb</a>
    (7)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1492.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1492.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1492.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1492.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1492">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLampHWjASVs73iyHI3Hn3kZovSIcks5rmClSgaJpZM4MeU4R">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLa4AJsU0tGl6qrTXzxV5UWtFBCPQks5rmClSgaJpZM4MeU4R.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1492"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Redaction factory (#1492)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1492"}}}</script>