<p>This PR contains more conversions to use the node factories. I've also added the <code>with_history</code> option to the node factory to create the correct number of old_nodes, for when a realistic history is required.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1506'>https://github.com/openstreetmap/openstreetmap-website/pull/1506</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add a with_history trait for node factories, to automatically create corresponding old_nodes</li>
  <li>Use factories for nodes in browse_helper tests.</li>
  <li>For deleted nodes created via factories, make sure the most recent old_node is also deleted</li>
  <li>Use node factories for browse_controller tests.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1506/files#diff-0">test/controllers/browse_controller_test.rb</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1506/files#diff-1">test/factories/node.rb</a>
    (19)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1506/files#diff-2">test/helpers/browse_helper_test.rb</a>
    (137)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1506/files#diff-3">test/models/redaction_test.rb</a>
    (10)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1506.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1506.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1506.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1506.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1506">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLUoUYZUJa-M4-2FviBKmblL3jDHFks5rq6dxgaJpZM4MuUu3">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLdvAaK14OOOXsGo1V5KbOJy6-RJxks5rq6dxgaJpZM4MuUu3.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1506"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"More node factories (#1506)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1506"}}}</script>