<p>The <a href="https://github.com/openstreetmap/openstreetmap-website/blob/e4e5ec44099eb3f21ee691058688cdd4e5d25e50/test/models/way_test.rb#L27-L41">way#test_max_nodes_per_way_limit</a> doesn't work. It looks like it keeps adding nodes until it reaches the limit, tests everything is fine, then adds on more and tests again.</p>
<p>Unfortunately the final test shows that the <code>valid?</code> is still true. So it's not really testing the limit at all. That was probably meant to be a final <code>assert !way.valid?</code></p>
<p>The root cause is that <a href="https://github.com/openstreetmap/openstreetmap-website/blob/e4e5ec44099eb3f21ee691058688cdd4e5d25e50/app/models/way.rb#L22-L30">the number of way_nodes isn't tested in any of the validations</a>, so the way is always valid no matter how many nodes are added. Instead we have a <code>preconditions_ok?</code> check that is called in some code paths (e.g. <code>save_with_history!</code> but, notably, not <code>save</code>)</p>
<p>Should we:</p>
<ol>
<li>Update the test to use the <code>preconditions_ok?</code> instead of <code>valid?</code><br>
or</li>
<li>Change the model so that the code in <code>preconditions_ok?</code> is used for all save methods (<code>save</code>, <code>save!</code> etc) and validity tests (i.e. <code>valid?</code>) via normal rails validations?<br>
or</li>
<li>Something else?</li>
</ol>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1516">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLZvqNk4CDV_aQghCAOINC262Ryrvks5rs3WOgaJpZM4M0Fa-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLUhVFnfoceRnxrm2OmzZM_0pCFWWks5rs3WOgaJpZM4M0Fa-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/issues/1516"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Problems with the way#test_max_nodes_per_way_limit (#1516)"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1516"}}}</script>