<p>This PR focusses on the api_controller tests, along with the old_node/way/relation controller tests.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1538'>https://github.com/openstreetmap/openstreetmap-website/pull/1538</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor remaining api_controller tests to use factories.</li>
  <li>Ensure the old nodes are created with the same changeset</li>
  <li>Convert remaining old_node_controller tests to use factories.</li>
  <li>Update old_ways_controller tests to use factories.</li>
  <li>Refactor old_relation_controller tests to use factories.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-0">test/controllers/api_controller_test.rb</a>
    (47)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-1">test/controllers/old_node_controller_test.rb</a>
    (166)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-2">test/controllers/old_relation_controller_test.rb</a>
    (132)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-3">test/controllers/old_way_controller_test.rb</a>
    (154)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-4">test/factories/node.rb</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-5">test/factories/relation.rb</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538/files#diff-6">test/factories/way.rb</a>
    (15)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1538.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1538.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1538.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1538.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1538">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLRgpCmF0SaR-ljvWY1sBMOiujTXnks5r4be9gaJpZM4NWpOJ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLQNrthuO8jZur4PMd-ZstIdB72fGks5r4be9gaJpZM4NWpOJ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1538"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"More factory refactoring (#1538)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1538"}}}</script>