<p>This is the final refactoring of the test suite to use factories. Finally!</p>
<p>I will make a separate PR for removing the fixtures, since I expect to find some tests that have hidden dependencies on the fixtures being loaded.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1555'>https://github.com/openstreetmap/openstreetmap-website/pull/1555</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor remaining way model tests to use factories.</li>
  <li>Refactor various controller tests to use factories.</li>
  <li>Refactor some controller tests to use factories.</li>
  <li>Refactor remaining relation model tests to use factories.</li>
  <li>Refactor some controller tests to use factories.</li>
  <li>refactor remaining amf controller tests to use factories.</li>
  <li>Update rubocop class length limit.</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-0">.rubocop_todo.yml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-1">test/controllers/amf_controller_test.rb</a>
    (38)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-2">test/controllers/browse_controller_test.rb</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-3">test/controllers/changeset_controller_test.rb</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-4">test/controllers/relation_controller_test.rb</a>
    (75)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-5">test/controllers/search_controller_test.rb</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-6">test/controllers/site_controller_test.rb</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-7">test/models/relation_test.rb</a>
    (50)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555/files#diff-8">test/models/way_test.rb</a>
    (57)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1555.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1555.patch</a></li>
  <li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1555.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1555.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1555">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLTo_ez7Sh5edIBOrXmUd98UjOme4ks5r_YbRgaJpZM4NrzIG">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLR2CbR9Qfo-jC7zmjpMYZilSSKucks5r_YbRgaJpZM4NrzIG.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1555"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Final Factory refactoring (#1555)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1555"}}}</script>