<p>This PR removes the test fixtures, and associated helper methods. It also fixes some tests that were implicitly relying on the test fixtures being in the database.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/openstreetmap/openstreetmap-website/pull/1556'>https://github.com/openstreetmap/openstreetmap-website/pull/1556</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Refactor changeset tags model test to remove dependency on fixtures.</li>
<li>Use a user factory in order to log in.</li>
<li>Create a redaction object before testing the index page lists it.</li>
<li>Add ways into the database explicitly, rather than relying on preloaded fixtures.</li>
<li>Create nodes explicitly rather than relying on fixtures.</li>
<li>Rework the changeset feed tests.</li>
<li>Create objects via factories, rather than implicity relying on fixtures.</li>
<li>Only use changesets from factories for the test_query changeset controller tests.</li>
<li>Refactor the assert_changeset helper to take an array of changesets, instead of ids.</li>
<li>Use the user factory to generate login details.</li>
<li>Use factories to generate the relations</li>
<li>Refactor the user list test to use factory-built users and explicit assertions.</li>
<li>Update the user list pagination test to avoid counting users from fixtures.</li>
<li>Update amf_controller tests to use a factory-generated user for credentials.</li>
<li>create nodes from factories for the api changes test.</li>
<li>Rubocop fixes.</li>
<li>Remove the api_fixtures helper</li>
<li>Remove remaining references to fixtures.</li>
<li>Remove test fixtures.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-0">.rubocop_todo.yml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-1">test/controllers/amf_controller_test.rb</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-2">test/controllers/api_controller_test.rb</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-3">test/controllers/browse_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-4">test/controllers/changeset_controller_test.rb</a>
(120)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-5">test/controllers/node_controller_test.rb</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-6">test/controllers/old_node_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-7">test/controllers/old_relation_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-8">test/controllers/old_way_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-9">test/controllers/redactions_controller_test.rb</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-10">test/controllers/relation_controller_test.rb</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-11">test/controllers/search_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-12">test/controllers/site_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-13">test/controllers/swf_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-14">test/controllers/user_blocks_controller_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-15">test/controllers/user_controller_test.rb</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-16">test/controllers/way_controller_test.rb</a>
(19)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-17">test/fixtures/changesets.yml</a>
(84)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-18">test/fixtures/current_nodes.yml</a>
(192)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-19">test/fixtures/current_relation_members.yml</a>
(61)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-20">test/fixtures/current_relations.yml</a>
(55)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-21">test/fixtures/current_way_nodes.yml</a>
(44)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-22">test/fixtures/current_ways.yml</a>
(48)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-23">test/fixtures/nodes.yml</a>
(234)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-24">test/fixtures/redactions.yml</a>
(7)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-25">test/fixtures/relation_members.yml</a>
(103)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-26">test/fixtures/relations.yml</a>
(99)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-27">test/fixtures/user_roles.yml</a>
(26)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-28">test/fixtures/users.yml</a>
(349)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-29">test/fixtures/way_nodes.yml</a>
(161)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-30">test/fixtures/ways.yml</a>
(99)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-31">test/helpers/browse_helper_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-32">test/integration/client_applications_test.rb</a>
(28)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-33">test/integration/user_diaries_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-34">test/models/changeset_comment_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-35">test/models/changeset_tag_test.rb</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-36">test/models/friend_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-37">test/models/message_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-38">test/models/node_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-39">test/models/node_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-40">test/models/note_comment_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-41">test/models/note_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-42">test/models/oauth_nonce_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-43">test/models/old_node_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-44">test/models/old_relation_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-45">test/models/old_relation_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-46">test/models/old_way_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-47">test/models/old_way_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-48">test/models/relation_member_test.rb</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-49">test/models/relation_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-50">test/models/relation_test.rb</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-51">test/models/request_token_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-52">test/models/user_test.rb</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-53">test/models/way_node_test.rb</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-54">test/models/way_tag_test.rb</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-55">test/models/way_test.rb</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556/files#diff-56">test/test_helper.rb</a>
(38)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1556.patch'>https://github.com/openstreetmap/openstreetmap-website/pull/1556.patch</a></li>
<li><a href='https://github.com/openstreetmap/openstreetmap-website/pull/1556.diff'>https://github.com/openstreetmap/openstreetmap-website/pull/1556.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1556">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLWzNADnoGfAVn2K2UFN-S_aRcbTxks5r_o4CgaJpZM4NsxL2">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLbJz-6VoWwx5rAgMuhflc0Jy45X-ks5r_o4CgaJpZM4NsxL2.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1556"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Remove fixtures (#1556)"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1556"}}}</script>