<blockquote>
<p>It's not true that controller tests don't render views by the way - they absolutely do.</p>
</blockquote>
<p>My mistake. Minitest (and rails, by default) have different setup and naming to what I'm used to with RSpec.</p>
<p>The tests were added in <a href="https://github.com/openstreetmap/openstreetmap-website/commit/fe1e28b4f45f6aa4bb53dc5163c187c5206b66a7" class="commit-link"><tt>fe1e28b</tt></a> . I will make sure to add "<a href="http://guides.rubyonrails.org/testing.html#system-testing">system</a>" tests instead of controller tests in future pull requests (e.g. <code>visit login_url</code>, <code>fill_in :email, :with => user.email</code> etc). But I won't keep this issue open here given there's no further specific actions required.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1570#issuecomment-313107205">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfevOmiPcSnQhalS_6xkfNLr0xFLks5sK5NYgaJpZM4OJSuQ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLWuuSOZgiDkQLeiZCSjJFTinixUxks5sK5NYgaJpZM4OJSuQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/issues/1570#issuecomment-313107205"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1570: \u003e It's not true that controller tests don't render views by the way - they absolutely do.\r\n\r\nMy mistake. Minitest (and rails, by default) have different setup and naming to what I'm used to with RSpec.\r\n\r\nThe tests were added in fe1e28b4f45f6aa4bb53dc5163c187c5206b66a7 . I will make sure to add \"[system](http://guides.rubyonrails.org/testing.html#system-testing)\" tests instead of controller tests in future pull requests (e.g. `visit login_url`, `fill_in :email, :with =\u003e user.email` etc). But I won't keep this issue open here given there's no further specific actions required."}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1570#issuecomment-313107205"}}}</script>