<blockquote>
<p>Assigning to tags is enough to trigger deletion of the old tags I take it?</p>
</blockquote>
<p>Yes. From <a href="http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many">http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many</a> :</p>
<p>"collection=objects :  Replaces the collections content by deleting and adding objects as appropriate."</p>
<blockquote>
<p>I certainly think that if we go this route we should change the method name to update_from_xml or something so that we don't have different models using the same name in different ways.</p>
</blockquote>
<p>OK, I can do that.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1614#issuecomment-323314557">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLUEkVdYFMUr32U9j1CO7UulGiJRuks5sZWIQgaJpZM4O7TcD">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLWzXLn9HPp-RvhXQOEXBJU0vRv0Qks5sZWIQgaJpZM4O7TcD.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1614#issuecomment-323314557"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1614: \u003e Assigning to tags is enough to trigger deletion of the old tags I take it?\r\n\r\nYes. From http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many :\r\n\r\n\"collection=objects :  Replaces the collections content by deleting and adding objects as appropriate.\"\r\n\r\n\u003e I certainly think that if we go this route we should change the method name to update_from_xml or something so that we don't have different models using the same name in different ways.\r\n\r\nOK, I can do that."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1614#issuecomment-323314557"}}}</script>