<p>I'm definitely pro system tests in general, but I found two issues with this PR to discuss:</p>
<ul>
<li>The screenshots appear as base64 output in my terminal (Ubuntu 16.04). >From <a href="https://github.com/rails/rails/pull/28185">a related pull request</a>, it seems some rails devs are aware that the inline images aren't supported by certain terminals. Should we disable them here, or report upstream?</li>
<li>The system tests aren't run by default. The <a href="http://guides.rubyonrails.org/testing.html#system-testing">rails docs confirms this</a>, but doesn't offer any way to change the behaviour. I think it's important that they are run alongside the model, controller and integration tests. What do you think?</li>
</ul>
<p>Beyond these, all looks good to me.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1664#issuecomment-344565273">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLeML3K7mJR9gtHQiR93tDhECgNJ3ks5s2srrgaJpZM4QLqZ5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLYtoSg0_lG3rZ0hDf9TwJ1y8j4sXks5s2srrgaJpZM4QLqZ5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1664#issuecomment-344565273"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gravitystorm in #1664: I'm definitely pro system tests in general, but I found two issues with this PR to discuss:\r\n\r\n* The screenshots appear as base64 output in my terminal (Ubuntu 16.04). From [a related pull request](https://github.com/rails/rails/pull/28185), it seems some rails devs are aware that the inline images aren't supported by certain terminals. Should we disable them here, or report upstream?\r\n* The system tests aren't run by default. The [rails docs confirms this](http://guides.rubyonrails.org/testing.html#system-testing), but doesn't offer any way to change the behaviour. I think it's important that they are run alongside the model, controller and integration tests. What do you think?\r\n\r\nBeyond these, all looks good to me."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1664#issuecomment-344565273"}}}</script>