<p>It looks like <a href="https://apidock.com/rails/ActionView/Helpers/UrlHelper/link_to_if" rel="nofollow"><code>link_to_if</code></a> isn't going to evaluate the link when <code>trace.inserted?</code> is false. I thnk that means that the trace will have non-nil lat/lon whenever <code>trace.inserted?</code> is true, so it shouldn't cause a problem?</p>
<p>There are some <a href="https://github.com/openstreetmap/openstreetmap-website/blob/609cedc4998805d38d1607e68c67e491ce589114/app/models/trace.rb#L182-L183">other places in the code</a> where we're assuming <code>inserted?</code> implies lat/lon are present.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1731#issuecomment-362902663">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLXHewe9tJyRxsR_hdOIOgErnmUheks5tRaCOgaJpZM4R4YyA">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLawL20eJvwi6IJ9UE5cGyY5scPINks5tRaCOgaJpZM4R4YyA.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1731#issuecomment-362902663"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zerebubuth in #1731: It looks like [`link_to_if`](https://apidock.com/rails/ActionView/Helpers/UrlHelper/link_to_if) isn't going to evaluate the link when `trace.inserted?` is false. I thnk that means that the trace will have non-nil lat/lon whenever `trace.inserted?` is true, so it shouldn't cause a problem?\r\n\r\nThere are some [other places in the code](https://github.com/openstreetmap/openstreetmap-website/blob/609cedc4998805d38d1607e68c67e491ce589114/app/models/trace.rb#L182-L183) where we're assuming `inserted?` implies lat/lon are present."}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1731#issuecomment-362902663"}}}</script>