<p><b>@bhousel</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1747#discussion_r167992830">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>> @@ -137,13 +138,36 @@ OSM.Directions = function (map) {
}
});
- function formatDistance(m) {
- if (m < 1000) {
- return Math.round(m) + "m";
- } else if (m < 10000) {
- return (m / 1000.0).toFixed(1) + "km";
+ $(".directions_form .distance_units a").on("click", function() {
+ $(".directions_form .distance_units a").removeClass("selected");
+ $(this).addClass("selected");
+ distanceUnits = $(this).data("unit");
+ getRoute();
+ });
+
+ function formatDistance(m, distanceUnits = "km") {
</pre>
<p>I'd avoid the ES6 Javascript here - it won't work on IE11.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1747#pullrequestreview-96290375">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLbpgDBdJZvhpLB6O7S1rE6jxL87Cks5tUfIsgaJpZM4SEGb1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLecDkoCjNuQWvVB8HTIk5IrwH_Nuks5tUfIsgaJpZM4SEGb1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1747#pullrequestreview-96290375"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bhousel commented on #1747"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1747#pullrequestreview-96290375"}}}</script>