<p><a href="https://github.com/openstreetmap/openstreetmap-website/blob/161ce947c3b753f68f5c6b27fea369d2e2b8c7ea/test/controllers/changeset_controller_test.rb#L622">https://github.com/openstreetmap/openstreetmap-website/blob/161ce947c3b753f68f5c6b27fea369d2e2b8c7ea/test/controllers/changeset_controller_test.rb#L622</a></p>
<p><code>cs.max_lat >= 90</code>  doesn't seem right and doesn't match the assert error message, probably a typo. Went unnoticed due the expansion logic.</p>
<p>I created a patch now to get rid of this logic altogether, including fixing the test suite issues.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/issues/1742#issuecomment-365422759">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLfyezDnuC-jdMizF84Qp-8p1WwxMks5tUgiugaJpZM4SB-SR">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLR4JxBZ-MCIZuVfb3GgDLvYqvmvCks5tUgiugaJpZM4SB-SR.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/issues/1742#issuecomment-365422759"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mmd-osm in #1742: https://github.com/openstreetmap/openstreetmap-website/blob/161ce947c3b753f68f5c6b27fea369d2e2b8c7ea/test/controllers/changeset_controller_test.rb#L622\r\n\r\n`cs.max_lat \u003e= 90`  doesn't seem right and doesn't match the assert error message, probably a typo. Went unnoticed due the expansion logic.\r\n\r\nI created a patch now to get rid of this logic altogether, including fixing the test suite issues.\r\n\r\n"}],"action":{"name":"View Issue","url":"https://github.com/openstreetmap/openstreetmap-website/issues/1742#issuecomment-365422759"}}}</script>