<p><b>@Zverik</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1779#discussion_r172872518">app/helpers/browse_helper.rb</a>:</p>
<pre style='color:#555'>> @@ -188,4 +190,16 @@ def telephone_link(_key, value)
 
     "tel:#{value_no_whitespace}"
   end
+
+  def colour_preview(key, value)
+    return nil unless (key =~ /^(|building:|ref:|roof:)colour$/ || key =~ /^(int_)?ref:colour(_(bg|tx))?$/) && !value.nil?
</pre>
<p>Thanks for trying different options. The long regular expression looks interesting, but it is not future-proof. I'd propose to use <code>/^(?:.+:)?colour$/</code> so that only <code>colour</code> or <code>whatever:colour</code> tags are matched.</p>
<p>I don't like variants with more suffixes, like <code>colour_tx</code> — that will catch wrong tags like <code>:colour_pattern</code> or apply only to local non-discussed tagging. Leading underscores are only used only in undocumented rare tags, so let's look only for semicolons.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1779#discussion_r172872518">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLdP5d4Tr-LhV1VVn3ZS4C1UakFTUks5tb_hugaJpZM4Sdsny">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABWnLVDIaZAQDe7G43syoi6TbqFMK-S3ks5tb_hugaJpZM4Sdsny.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1779#discussion_r172872518"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@Zverik commented on #1779"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1779#discussion_r172872518"}}}</script>