<p><b>@tomhughes</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1800#discussion_r178182868">app/assets/javascripts/index/directions.js</a>:</p>
<pre style='color:#555'>> @@ -86,7 +90,8 @@ OSM.Directions = function (map) {
endpoint.awaitingGeocode = false;
endpoint.hasGeocode = true;
if (json.length === 0) {
- alert(I18n.t('javascripts.directions.errors.no_place'));
+ alert(I18n.t('javascripts.directions.errors.no_place_with_name', {place: endpoint.value}));
+ input.css("background-color", "rgba(255, 0, 0, 0.5)");
</pre>
<p>Rather than manipulating CSS directly like this please add a new rule to the style sheet that is triggered by a class and then add and remove the class in javascript.</p>
<hr>
<p>In <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1800#discussion_r178183002">config/locales/en.yml</a>:</p>
<pre style='color:#555'>> @@ -2326,6 +2326,7 @@ en:
errors:
no_route: "Couldn't find a route between those two places."
no_place: "Sorry - couldn't find that place."
+ no_place_with_name: "Sorry - couldn't locate '%{place}'."
</pre>
<p>Can the old <code>no_place</code> translation be removed? or does something else use it still?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/openstreetmap/openstreetmap-website/pull/1800#pullrequestreview-108205899">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABWnLVDd-8kYTfiWwoNANZ13sAxR8TGVks5tjU5zgaJpZM4TA5g2">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABWnLYtaI---nZ43p0qjm5PkwJQXNzXuks5tjU5zgaJpZM4TA5g2.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/openstreetmap/openstreetmap-website/pull/1800#pullrequestreview-108205899"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/openstreetmap/openstreetmap-website","title":"openstreetmap/openstreetmap-website","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/openstreetmap/openstreetmap-website"}},"updates":{"snippets":[{"icon":"PERSON","message":"@tomhughes requested changes on #1800"}],"action":{"name":"View Pull Request","url":"https://github.com/openstreetmap/openstreetmap-website/pull/1800#pullrequestreview-108205899"}}}</script>